Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add secondary interface output address #553

Merged
merged 10 commits into from
Oct 10, 2023
Merged

feat: add secondary interface output address #553

merged 10 commits into from
Oct 10, 2023

Conversation

jor2
Copy link
Member

@jor2 jor2 commented Oct 4, 2023

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

  • When merging, use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
  • Merge by using "Squash and merge".

@jor2 jor2 self-assigned this Oct 4, 2023
@jor2
Copy link
Member Author

jor2 commented Oct 4, 2023

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Oct 4, 2023

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Oct 4, 2023

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Oct 4, 2023

/run pipeline

@jor2 jor2 requested a review from ocofaigh October 4, 2023 13:10
@jor2
Copy link
Member Author

jor2 commented Oct 4, 2023

/run pipeline

1 similar comment
@jor2
Copy link
Member Author

jor2 commented Oct 4, 2023

/run pipeline

ocofaigh
ocofaigh reviewed Oct 6, 2023
View reviewed changes
outputs.tf Outdated
id = virtual_server.id
zone = virtual_server.zone
ipv4_address = virtual_server.primary_network_interface[0].primary_ipv4_address
secondary_ipv4_address = length(virtual_server.network_interfaces) == 0 ? "" : virtual_server.network_interfaces[0].primary_ipv4_address
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you default to empty string instead of null when the length is 0?

@jor2
Copy link
Member Author

jor2 commented Oct 6, 2023

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Oct 8, 2023

/run pipeline

1 similar comment
@ocofaigh
Copy link
Member

ocofaigh commented Oct 9, 2023

/run pipeline

@ocofaigh
Copy link
Member

ocofaigh commented Oct 9, 2023

Pipeline failed with Error: [ERROR] Error creating authorization policy: The policy wasn't created because an access policy with identical attributes already exists. Please update the roles in the existing policy (75e0e543-f538-450e-a27b-3ce460919c35), or update the one you're trying to assign to include a different attribute assignment.
@jor2 you probably need to manually delete this auth policy from our account so this can pass

@jor2
Copy link
Member Author

jor2 commented Oct 9, 2023

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Oct 9, 2023

Pipeline failed with Error: [ERROR] Error creating authorization policy: The policy wasn't created because an access policy with identical attributes already exists. Please update the roles in the existing policy (75e0e543-f538-450e-a27b-3ce460919c35), or update the one you're trying to assign to include a different attribute assignment. @jor2 you probably need to manually delete this auth policy from our account so this can pass

passing

@ocofaigh ocofaigh merged commit 2af91de into main Oct 10, 2023
2 checks passed
@ocofaigh ocofaigh deleted the output branch October 10, 2023 09:39
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocofaigh ocofaigh ocofaigh approved these changes

Assignees

@jor2 jor2

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jor2 @ocofaigh @terraform-ibm-modules-ops