fix: Security group for secondary interface #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 8, 2023 21:35
jor2
commented
Oct 9, 2023
| @@ -135,7 +135,13 @@ resource "ibm_is_instance" "vsi" { | |||
| } | |||
| content { | |||
| subnet = network_interfaces.value.id | |||
| security_groups = flatten([ | |||
| security_groups = length(flatten([ | |||
There was a problem hiding this comment.
@ocofaigh any ideas how I could avoid code duplication here?
There was a problem hiding this comment.
@jor2 Its pretty hard to follow that logic - could you maybe add some code comments to explain what its doing?
There was a problem hiding this comment.
Added some comments. It just checks if security group list is empty don't pass empty list, instead pass default security group. This avoid reapply failures.
There was a problem hiding this comment.
ok thanks, comment is good. As for code duplication, have you tried using locals?
|
/run pipeline |
2 similar comments
|
/run pipeline |
|
/run pipeline |
ocofaigh
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously when security groups for secondary interface was left empty, it would default to the default security group being attached, but on reapply terraform would find changes in the secondary vsi configs due to the default sg being attached, but the security group parameter empty in terraform.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers