Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for module #63

Open
ocofaigh opened this issue Apr 26, 2024 · 2 comments
Open

Add example for module #63

ocofaigh opened this issue Apr 26, 2024 · 2 comments
Assignees
Labels
deferred Issues to be fixed in future release

Comments

@ocofaigh
Copy link
Member

In #56 the code was refactored so the root level code would contain a module, and the solutions folder would contain the DA (that just calls the module).

Whenever you have a module, you should have at least a basic example in the examples folder showing how the module can be used. And whenever you have an example, there should be a test for it. In this case, since we have tests for the DA itself, maybe add the test to other_test.go and have it run weekly in the DAF teams continuous test pipeline.

@NatarajBTI
Copy link
Contributor

As agreed, we are keeping this issue in deferred state as we need to add the end-to-end test from deploying a Openshift cluster & then MAS DA example on top of it.

@ocofaigh
Copy link
Member Author

ocofaigh commented May 9, 2024

A basic example was added here however it needs to be extended to be a full end to end example that provisions the cluster and all prereqs. Since its a basic example it doesn't have to be a landing zone cluster, maybe just use the IBM provider directly to create a small scale OCP cluster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deferred Issues to be fixed in future release
Projects
None yet
Development

No branches or pull requests

2 participants