Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip upgrade test #64

Closed
ocofaigh opened this issue Apr 26, 2024 · 6 comments
Closed

Unskip upgrade test #64

ocofaigh opened this issue Apr 26, 2024 · 6 comments
Assignees
@ocofaigh

Comments

@ocofaigh
Copy link
Member

After #56 is merged, the upgrade test should be enabled by removing this line of code: t.Skip("Skipping upgrade test until solution is in the main branch") from tests/pr_test.go
@NatarajBTI
Copy link
Contributor

@ocofaigh - Can we close this issue? as #56 is merged now..

@ocofaigh
Copy link
Member Author

ocofaigh commented May 8, 2024

@NatarajBTI Nope, the upgrade test has not yet been enabled. We can enabled it after we determine the GA release version

@NatarajBTI
Copy link
Contributor

@NatarajBTI - Ok..thanks..So is this issue a candidate to be deferred?

@ocofaigh
Copy link
Member Author

ocofaigh commented May 9, 2024

Don't defer it - as soon as we identify release candidate (hopefully today), we will enable the upgrade test

@ocofaigh ocofaigh assigned ocofaigh and unassigned NatarajBTI May 10, 2024
@ocofaigh
Copy link
Member Author

I can create a PR for this today

@ocofaigh ocofaigh mentioned this issue May 10, 2024
Merged
6 tasks
@ocofaigh
Copy link
Member Author

PR: #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocofaigh ocofaigh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ocofaigh @NatarajBTI