Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[terraform-ibm-scc-da] Add support to create KMS key in external account #107

Open
ocofaigh opened this issue Jun 7, 2024 · 1 comment

Comments

@ocofaigh
Copy link
Member

ocofaigh commented Jun 7, 2024

Changes should go into solutions/instances only..

  • Add new optional variable ibmcloud_kms_api_key. This should be used in the kms provider block like so:
    provider "ibm" {
      alias            = "kms"
      ibmcloud_api_key = var.ibmcloud_kms_api_key != null ? var.ibmcloud_kms_api_key : var.ibmcloud_api_key
      region           = local.kms_region 
    }
    
  • The kms module block should use the kms provider alias.
  • Support creating cross account s2s auth policy (in KMS account)
  • Review all of the variable descriptions and readme markdowns to ensure its clear that it supports KMS in a different account using the ibmcloud_kms_api_key variable.
@kierramarie
Copy link

following a method similar to this other PR: terraform-ibm-modules/terraform-ibm-event-notifications#230 which is based on Jordan Williams solution for observability da.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants