feat: add supported services #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocofaigh
requested changes
May 18, 2023
|
@ocofaigh I tried locally testing all of them but they are quite unstable when you try to create/destroy each one of them together - most of them are created/destroyed in seconds. I think that might be because each one of them is associated with the same VPC and resource group. Even with only 2 services testing they are hit and miss, especially observed while destroying. If you say I can create a separate task to investigate further if there is a possibility to do that maybe by dividing a bunch of services across multiple VPCs or adding a timeout. |
|
Further investigation on the error in this run https://github.com/terraform-ibm-modules/terraform-ibm-vpe-module/actions/runs/5012951676: Will be CreatedCreation PhaseRefreshing PhaseWill be destroyedDestroy PhaseConclusion:All the resources which are created are destroyed successfully. I am not sure what does it attempt to destroy further on, hence throw |
…es/terraform-ibm-vpe-module into add-services-support
|
Hello @rajatagarwal-ibm @ocofaigh - where are we on this PR - it seems to have been abandoned? |
|
@vburckhardt Brought it up with Rajat earlier - he will be handing it over to someone tomorrow to complete since he is off for a few weeks |
|
@vburckhardt I'd say we need to create a support case/provider issue to complete this task. I have unassigned myself from the issue for now as I have been going on vacation. If no one else picks that up, I will have a look again. |
|
@vburckhardt the above issue was highly impacted by the error "Target not found". There is an issue open for this https://github.ibm.com/GoldenEye/issues/issues/4527 |
|
/run pipeline |
|
/run pipeline |
|
The upgrade test on PR validation has been skipped due to changes in the test code and new services not being available in the main branch. Manual tests have been run locally. Checking out main branch, manually deploying examples/default with 3 VPE gateways, running a terraform plan, loading this branch, re-running terraform init --upgrade and then terraform plan again. Both plans identified that the vpe_ips output, which was empty lists, was due to be updated with current IP values. There were no changes to the resources. |
ocofaigh
approved these changes
Aug 3, 2023
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #307
Add supported services for the VPE
Could not find the following services in the UI and cannot find the VPE endpoints for them:
Removed validation from the example as that's already covered in the main module.
#307
Types of changes in this PR
Changes that affect the core Terraform module or submodules
Changes that don't affect the core Terraform module or submodules
Release required?
Identify the type of release. For information about the changes in a semantic versioning release, see Release versioning.
x.x.X)x.X.x)X.x.x)Release notes content
If a release is required, replace this text with information that users need to know about the release. Write the release notes to help users understand the changes, and include information about how to update from the previous version.
Your notes helps the merger write the commit message for the PR that is published in the release notes for the module.
Checklist for reviewers
Merge actions for mergers