Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove hyperb-postgres and hyperb-mongodb #520

Merged
merged 2 commits into from
May 1, 2024
Merged

fix: remove hyperb-postgres and hyperb-mongodb #520

merged 2 commits into from
May 1, 2024

Conversation

jor2
Copy link
Member

@jor2 jor2 commented May 1, 2024

Description

tests are failing due to end of life for mongodb and postgres

TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │ Error: [ERROR] Create Endpoint Gateway failed Service not found in global catalog
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │ {
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │     "StatusCode": 400,
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │     "Headers": {
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         "Allow-Snippet-Annotations": [
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │             "true"
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         ],
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         "Cache-Control": [
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │             "max-age=0, no-cache, no-store, must-revalidate"
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         ],
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         "Cf-Cache-Status": [
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │             "DYNAMIC"
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         ],
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         "Cf-Ray": [
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │             "8751b7d9dba63593-DFW"
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         ],
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         "Content-Length": [
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │             "292"
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         ],
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         "Content-Type": [
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │             "application/json"
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         ],
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         "Date": [
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │             "Tue, 16 Apr 2024 05:19:03 GMT"
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         ],
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         "Expires": [
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │             "-1"
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         ],
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         "Pragma": [
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │             "no-cache"
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         ],
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         "Server": [
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │             "cloudflare"
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         ],
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         "Strict-Transport-Security": [
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │             "max-age=31536000; includeSubDomains"
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         ],
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         "Vary": [
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │             "Accept-Encoding"
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         ],
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         "X-Content-Type-Options": [
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │             "nosniff"
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         ],
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         "X-Request-Id": [
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │             "9c8a71dc-f27d-47ff-8f72-d7d496dd0496"
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         ],
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         "X-Xss-Protection": [
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │             "1; mode=block"
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         ]
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │     },
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │     "Result": {
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         "errors": [
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │             {
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │                 "code": "bad_field",
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │                 "message": "Service not found in global catalog",
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │                 "target": {
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │                     "name": "Crn",
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │                     "type": "field",
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │                     "value": "crn:v1:bluemix:public:hyperp-dbaas-mongodb:us-south:::endpoint:dbaas900-mongodb.private.hyperp-dbaas.cloud.ibm.com"
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │                 }
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │             }
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         ],
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │         "trace": "9c8a71dc-f27d-47ff-8f72-d7d496dd0496"
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │     },
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │     "RawResult": null
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │ }
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │ 
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │ 
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │   with module.vpes.ibm_is_virtual_endpoint_gateway.vpe["vpe-allmt-uuhfmw-hyperp-mongodb"],
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │   on ../../main.tf line 84, in resource "ibm_is_virtual_endpoint_gateway" "vpe":
TestRunEveryMultiTenantExample 2024-04-16T05:25:21Z logger.go:66: │   84: resource "ibm_is_virtual_endpoint_gateway" "vpe" {

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Remove hyper dba config due to service having end of life the end of March.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this May 1, 2024
@jor2
Copy link
Member Author

jor2 commented May 1, 2024

/run pipeline

@toddgiguere toddgiguere merged commit 1583b5c into main May 1, 2024
2 checks passed
@toddgiguere toddgiguere deleted the test branch May 1, 2024 13:18
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 4.1.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ocofaigh
Copy link
Member

ocofaigh commented May 1, 2024

Probably should have been a minor release as removing support for something. see guidelines at https://terraform-ibm-modules.github.io/documentation/#/versioning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants