chore(deps): update terraform-module

[terraform-ibm-modules-ops]

This PR contains the following updates:

Package	Type	Update	Change
terraform-ibm-modules/icd-postgresql/ibm (source)	module	minor	3.12.0 -> 3.14.0
terraform-ibm-modules/landing-zone-vpc/ibm (source)	module	patch	7.18.0 -> 7.18.2

---

Release Notes

terraform-ibm-modules/terraform-ibm-icd-postgresql (terraform-ibm-modules/icd-postgresql/ibm)

v3.14.0

Compare Source

Features

• add missing configuration parameters and add validations for plan-time (#​424) (a3fc547)

v3.13.1

Compare Source

Bug Fixes

• deps: update terraform-module (#​363) (dbdfc3a)

v3.13.0

Compare Source

Features

• added support to set log_disconnections and log_connections in the configuration input variable object (#​421) (57d9068)

terraform-ibm-modules/terraform-ibm-landing-zone-vpc (terraform-ibm-modules/landing-zone-vpc/ibm)

v7.18.1

Compare Source

Bug Fixes

• added fix to ensure vpc_data is always output after initial apply (#​781) (069d418)

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Renovate Bot.

[terraform-ibm-modules-dev]

/run pipeline

[terraform-ibm-modules-dev]

/run pipeline

[terraform-ibm-modules-dev]

/run pipeline

[terraform-ibm-modules-dev]

/run pipeline

[terraform-ibm-modules-dev]

/run pipeline

[terraform-ibm-modules-dev]

/run pipeline

[terraform-ibm-modules-dev]

/run pipeline

[ocofaigh]

@toddgiguere @shemau The test failed with:

│ Error: Invalid for_each argument
│ 
│   on ../../main.tf line 85, in resource "ibm_is_virtual_endpoint_gateway" "vpe":
│   85:   for_each = { # Create a map based on gateway name
│   86:     for gateway in local.gateway_list :
│   87:     (gateway.name) => gateway
│   88:   }
│     ├────────────────
│     │ local.gateway_list is tuple with 30 elements
│ 

As codeowners could you take a look, as this blocks us from merging #532 which has the update to move to tf 1.6.6

[shemau]

The bump to landing-zone-vpc changed how the module output the vpc.name.

The actual error followed the snippet above

│ The "for_each" map includes keys derived from resource attributes that
│ cannot be determined until apply, and so Terraform cannot determine the
│ full set of keys that will identify the instances of this resource.
│ 
│ When working with unknown values in for_each, it's better to define the map
│ keys statically in your configuration and place apply-time results only in
│ the map values.
│ 

The vpc_name may now be generated by the module and becomes derived during the apply. The default example was not impacted, because it passes the same name to both the VPC module and the VPE module. This is not the most elegant solution, since the module can prefix/extend the name, so technically it is not the VPC name. However, it works, because we then use the name without prefix for the names of the gateways and reserved IPs. This is still enough to identify them.

The main module is not changing, so there is no risk of regression/change.

[ocofaigh]

@shemau Lets update to 7.18.2 and see if it passes

[shemau]

/run pipeline

[ocofaigh]

Postgres install failed with:

2024-06-06T15:42:28.8011205Z TestRunDefaultExample 2024-06-06T15:42:28Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; �[31m╷�[0m�[0m
2024-06-06T15:42:28.8013652Z �[31m│�[0m �[0m�[1m�[31mError: �[0m�[0m�[1mInternal Server Error�[0m
2024-06-06T15:42:28.8016913Z �[31m│�[0m �[0m
2024-06-06T15:42:28.8017699Z �[31m│�[0m �[0m�[0m  with module.postgresql_db.ibm_database.postgresql_db,
2024-06-06T15:42:28.8019229Z �[31m│�[0m �[0m  on .terraform/modules/postgresql_db/main.tf line 55, in resource "ibm_database" "postgresql_db":
2024-06-06T15:42:28.8020649Z �[31m│�[0m �[0m  55: resource "ibm_database" "postgresql_db" �[4m{�[0m�[0m
2024-06-06T15:42:28.8021454Z �[31m│�[0m �[0m

Going to retry..

[ocofaigh]

/run pipeline

[ocofaigh]

Hmm, upgrade test failed with:

2024-06-06T17:20:43.5743221Z         	Messages:   	Resource(s) identified to be updated 
2024-06-06T17:20:43.5744150Z         	            	Name: security_group_rule
2024-06-06T17:20:43.5745512Z         	            	Address: module.vpe_security_group.ibm_is_security_group_rule.security_group_rule["allow-all-default-sg-inbound"]
2024-06-06T17:20:43.5746660Z         	            	Actions: [update]
2024-06-06T17:20:43.5747185Z         	            	DIFF:
2024-06-06T17:20:43.5747627Z         	            	  Before: 
2024-06-06T17:20:43.5748364Z         	            		{"remote":"r006-f2b664ea-7271-40e1-9b41-c5ebc1d4697d"}
2024-06-06T17:20:43.5749049Z         	            	  After: 
2024-06-06T17:20:43.5749533Z         	            		{}

@shemau are we expecting this, or know why its happening?

[shemau]

I was not expecting that. 7.18.0 to 7.18.2 should only have been adding a delay and a new data source.

I will dig into the logs, but will probably run the test again.

[shemau]

/run pipeline

[shemau]

/run pipeline

[terraform-ibm-modules-ops]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

[ocofaigh]

/run pipeline

[ocofaigh]

I have reverted the VPC module update to see if pipeline passes

[ocofaigh]

/run pipeline

[ocofaigh]

/run pipeline

[ocofaigh]

So even after removing the the VPC update from this PR, the same error occurs:

        	            	Address: module.vpe_security_group.ibm_is_security_group_rule.security_group_rule["allow-all-default-sg-inbound"]
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"remote":"r006-337b8e0a-2aaf-431e-884e-d1ec3addadec"}
        	            	  After: 
        	            		{}

Since its unrelated to the module, and just updates to the examples, I'm going to add back newer vpc version, and skip upgrade test

[ocofaigh]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 4.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀