Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added eu-es region in registry mapping endpoints and readme and input var #539

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

vbontempi
Copy link
Member

Description

  • Add support for eu-es region in container-registry CRN for VPE creation
  • Fix documentation missing of subnet ID in the subnets list in input
  • Removed optional from zone attribute in subnets list input as it is used when building VPE IP names

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Add support for eu-es region in container-registry CRN for VPE creation
Fix documentation missing of subnet ID in the subnets list in input
Removed optional from zone attribute in subnets list input

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@vbontempi vbontempi changed the title fix: added eu-es region in registry mapping and fixed zone and docs Added eu-es region in registry mapping endpoints and readme and input var Jun 17, 2024
@vbontempi
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit f66efd4 into main Jun 17, 2024
2 checks passed
@ocofaigh ocofaigh deleted the fix_registry_es branch June 17, 2024 11:11
@ocofaigh ocofaigh mentioned this pull request Jun 17, 2024
6 tasks
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 4.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants