-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update references #329
Update references #329
Conversation
/run pipeline |
1 similar comment
/run pipeline |
/run pipeline |
1 similar comment
/run pipeline |
FYI there was a bug in the pipeline config for this repo which has been fixed in #331 which was just merged. Pipeline should now run.. |
/run pipeline |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upgrade test is failing on:
Resource(s) identified to be updated Name: network_acl Address: module.vpc[0].ibm_is_network_acl.network_acl["vpc-acl"]
I'm guessing this is due to the fact you are updating the vpc module from 7.2.0 to 7.3.0. Since this updated is unrelated to the VPE module itself, I would suggest skipping upgrade test to get this PR to pass
/run pipeline |
/run pipeline |
🎉 This PR is included in version 2.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Updated references as part of https://github.ibm.com/GoldenEye/issues/issues/4214
Types of changes in this PR
Changes that affect the core Terraform module or submodules
Changes that don't affect the core Terraform module or submodules
Release required?
Identify the type of release. For information about the changes in a semantic versioning release, see Release versioning.
x.x.X
)x.X.x
)X.x.x
)Release notes content
If a release is required, replace this text with information that users need to know about the release. Write the release notes to help users understand the changes, and include information about how to update from the previous version.
Your notes help the merger write the commit message for the PR that is published in the release notes for the module.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
Merge actions for mergers