Networking v2: Add no_fixed_ip to openstack_networking_port_v2 #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `no_fixed_ip` argument to the openstack_networking_port_v2 resource which will enable a port to be created without a Fixed IP address set.
ghost
added
the
|
Build succeeded.
|
| // | ||
| // Since we're only concerned about a value of "true", | ||
| // GetOk is used. | ||
| if _, ok := d.GetOk("no_fixed_ip"); ok { |
There was a problem hiding this comment.
Maybe it's better to hide this logic in the resourcePortFixedIpsV2? Because it doesn't make sense to run resourcePortFixedIpsV2 if no_fixed_ip was set.
There was a problem hiding this comment.
Sounds good to me. See the latest commit.
|
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
no_fixed_ipargument to theopenstack_networking_port_v2 resource which will enable a port to
be created without a Fixed IP address set.
For #429