Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags support for Neutron Routers #467

Merged

Conversation

hardys
Copy link
Contributor

@hardys hardys commented Oct 31, 2018

This adds support for tags to routers

Issue #453

Steven Hardy added 2 commits October 31, 2018 09:57
This allows us to set/get tags for floatingips via terraform templates,
and requires the recently added changes to gophercloud that enable
the relevant features of the Neutron APIs to be accessed.

Issue: terraform-provider-openstack#453
This allows us to set/get tags for routers via terraform templates,
and requires the recently added changes to gophercloud that enable
the relevant features of the Neutron APIs to be accessed.

Issue: terraform-provider-openstack#453
@ghost ghost added the size/M label Oct 31, 2018
@hardys hardys mentioned this pull request Oct 31, 2018
9 tasks
@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 31, 2018

Build succeeded.

Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jtopjian jtopjian merged commit 8a4e921 into terraform-provider-openstack:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants