Provider: Fix flavor detection #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that Terraform v0.12 won't use DefaultFunc when the field is set to computed. While this might be a bug, we only have a few occurrences of this in the provider, so I'm opting to work around this instead of reporting it upstream and possibly have a legacy measure put in place. This commit will have the flavors still use the correct environment variables. Detection is just deferred to outside the schema.
ghost
added
the
|
Build succeeded.
|
ozerovandrei
approved these changes
Dec 20, 2018
|
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #548
It appears that Terraform v0.12 won't use DefaultFunc when the field is
set to computed. While this might be a bug, we only have a few
occurrences of this in the provider, so I'm opting to work around this
instead of reporting it upstream and possibly have a legacy measure put
in place.
This commit will have the flavors still use the correct environment
variables. Detection is just deferred to outside the schema.
In addition, I made an update to the compute instance test fixtures so they work in v0.12.
@ozerovandrei These changes probably conflict with #545, but this PR should take priority. I will resolve any conflicts with #545 afterwards.