Networking: add port data source #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
jtopjian
reviewed
Jan 6, 2019
|
Build succeeded.
|
kayrus
changed the title
kayrus
force-pushed
the
port-data-sources
branch
from
8913a9b
to
983ea59
Compare
|
Build succeeded.
|
|
Build succeeded.
|
|
@jtopjian I believe I added enough filters, ready for review. |
|
@kayrus Thanks! It looks like HashiCorp is applying some blanket changes to all providers, which I only learned about today. One change involves some struct declaration modifications. I'm going to hold off on reviewing this until this is resolved. You'll need to make similar changes here for consistency and, until it's resolved, we can't be certain what all of those changes are. :/ |
|
@jtopjian, could you please clarify which changes do you mean? Any references? |
|
#570 is merged. It looks like the struct changes are the only changes to make. |
|
Build succeeded.
|
kayrus
force-pushed
the
port-data-sources
branch
from
15811dd
to
2ea5236
Compare
|
Build succeeded.
|
jtopjian
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the #512