Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Networking V2: add Address-scope resource #634

Merged
merged 9 commits into from
Jan 24, 2019
Merged

Networking V2: add Address-scope resource #634

merged 9 commits into from
Jan 24, 2019

Conversation

ozerovandrei
Copy link
Member

Add "openstack_networking_addressscope_v2" resource with acceptance and importing test.

Add website documentation for the addressscope_v2 resource.

For #364

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 20, 2019

Build failed.

jtopjian
jtopjian requested changes Jan 20, 2019
View reviewed changes
Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ozerovandrei overall this looks good. Travis is reporting an issue with vendoring - can you try to re-vendor? In addition, can you make sure all of Gophercloud is on the same commit?

govendor fetch github.com/gophercloud/gophercloud/...

I left one comment with regard to value_specs. Tests are crashing for me - I'm not sure why OpenLab didn't have a crash.

openstack/types.go Outdated Show resolved Hide resolved
@ghost ghost added size/XXL and removed size/XL labels Jan 21, 2019
@ozerovandrei
Copy link
Member Author

ozerovandrei commented Jan 21, 2019 •
edited

Hmm, that's interesting:

$ make vet
go vet .
# github.com/terraform-providers/terraform-provider-openstack/openstack
openstack/resource_openstack_lb_l7policy_v2.go:24: github.com/terraform-providers/terraform-provider-openstack/vendor/github.com/hashicorp/terraform/helper/schema.ResourceImporter composite literal uses unkeyed fields
openstack/resource_openstack_lb_l7rule_v2.go:23: github.com/terraform-providers/terraform-provider-openstack/vendor/github.com/hashicorp/terraform/helper/schema.ResourceImporter composite literal uses unkeyed fields
openstack/resource_openstack_lb_member_v2.go:22: github.com/terraform-providers/terraform-provider-openstack/vendor/github.com/hashicorp/terraform/helper/schema.ResourceImporter composite literal uses unkeyed fields
openstack/resource_openstack_lb_pool_v2.go:21: github.com/terraform-providers/terraform-provider-openstack/vendor/github.com/hashicorp/terraform/helper/schema.ResourceImporter composite literal uses unkeyed fields
openstack/resource_openstack_sharedfilesystem_share_access_v2.go:23: github.com/terraform-providers/terraform-provider-openstack/vendor/github.com/hashicorp/terraform/helper/schema.ResourceImporter composite literal uses unkeyed fields
The command "make vet" exited with 0.

I created a PR with fix: #635

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 21, 2019

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 22, 2019

Build failed.

jtopjian
jtopjian reviewed Jan 23, 2019
View reviewed changes
vendor/vendor.json Outdated Show resolved Hide resolved
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 23, 2019

Build failed.

jtopjian
jtopjian requested changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this isn't crashing on me, I can see why the test is failing. :)

openstack/resource_openstack_networking_addressscope_v2.go Outdated Show resolved Hide resolved
openstack/import_openstack_networking_addressscope_v2_test.go Outdated Show resolved Hide resolved
openstack/resource_openstack_networking_addressscope_v2.go Outdated Show resolved Hide resolved
@ozerovandrei
Vendor: add "address-scopes" support
2c28335 
Add Gophercloud "networking/v2/extensions/layer3/addressscopes" package.
@ozerovandrei
Networking V2: add Address-scope resource
a407218 
Add "openstack_networking_addressscope_v2" resource with acceptance
test.
@ozerovandrei
Networking V2: add Address-scope import test
e33dd2a 
Add TestAccNetworkingV2AddressScopeImportBasic() acceptance test.
@ozerovandrei
Networking V2: add Address-scopes docs
4b80f06 
Add website documentation for the addressscope_v2 resource.
@ozerovandrei
Vendor: sync Gophercloud
f5c1368 
Use e102249148e2e09eb5efab07b7c3ea74c161e935 commit.
@ozerovandrei
Networking V2 Addr scopes: remove value specs
8f78d8a 
Remove unused value_specs as it won't be used for now.
@ozerovandrei
Vendor: fix address-scopes dependency
ca7edec 
Fetch only e102249148e2e09eb5efab07b7c3ea74c161e935 commit for Neutron
address-scopes extension.
@ozerovandrei
Vendor: remove unversioned address-scopes
f26c265 
Run govendor remove on bad dependency.
@ozerovandrei
Networking V2 Addr scopes: fix create
dd4299b 
Run resourceNetworkingAddressScopeV2Read() after Create method.

This commit also removes unnecessary d.SetId("") from the Delete method
and renames import test.
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 24, 2019

Build succeeded.

jtopjian
jtopjian approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozerovandrei ozerovandrei merged commit 68fb125 into terraform-provider-openstack:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtopjian jtopjian jtopjian approved these changes

Assignees
No one assigned
Labels
dependencies documentation size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ozerovandrei @jtopjian