Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute V2: Don't fail on delete, when compute instance doesn't exist #647

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Compute V2: Don't fail on delete, when compute instance doesn't exist #647

merged 1 commit into from
Jan 30, 2019

Conversation

kayrus
Copy link
Collaborator

@kayrus kayrus commented Jan 29, 2019

For #456

@ghost ghost added the size/XS label Jan 29, 2019
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 29, 2019

Build succeeded.

@kayrus
Copy link
Collaborator Author

kayrus commented Jan 30, 2019

@jtopjian ready for review

jtopjian
jtopjian approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 86a9650 into terraform-provider-openstack:master Jan 30, 2019
@kayrus kayrus deleted the instance-delete branch January 30, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtopjian jtopjian jtopjian approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kayrus @jtopjian