Identity V3: Add application credential resource #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayrus
changed the title
kayrus
force-pushed
the
create-app-cred
branch
2 times, most recently
from
d45bf77
to
e6b6f85
Compare
kayrus
changed the title
ghost
added
|
Build failed.
|
kayrus
force-pushed
the
create-app-cred
branch
from
e6b6f85
to
8748988
Compare
|
Build succeeded.
|
|
Build succeeded.
|
kayrus
force-pushed
the
create-app-cred
branch
from
5e34772
to
7f41e0b
Compare
|
Build succeeded.
|
kayrus
force-pushed
the
create-app-cred
branch
from
7f41e0b
to
11b8462
Compare
|
Build succeeded.
|
kayrus
force-pushed
the
create-app-cred
branch
from
11b8462
to
e683238
Compare
kayrus
changed the title
|
Build succeeded.
|
kayrus
commented
Feb 15, 2019
| @@ -105,7 +105,7 @@ func dataSourceIdentityAuthScopeV3Read(d *schema.ResourceData, meta interface{}) | |||
| } | |||
|
|
|||
| d.Set("user_name", user.Name) | |||
| d.Set("user_id", user.Name) | |||
| d.Set("user_id", user.ID) | |||
There was a problem hiding this comment.
if you think, this can break anything, let me know - I'll remove this.
There was a problem hiding this comment.
I think this can constitute as a legitimate bug.
There was a problem hiding this comment.
is it ok to leave it here, or should I create a dedicated PR?
There was a problem hiding this comment.
This should really be a dedicated PR since it's has nothing to do with this PR and will have a changelog entry. We can leave this here, but something to keep in mind for future changes.
jtopjian
approved these changes
Feb 17, 2019
|
Do you have an estimate on when the go module work is finished? |
|
@kayrus We can begin merging vendor changes. The procedure to modify the vendor dependencies is: $ go get github.com/gophercloud/gophercloud@new-version
$ go mod tidy
$ go mod vendor |
|
I don't think it is necessary. The latest changes are sufficient. The commands you provided just bump the gophercloud to the latest gophercloud commit, but doesn't change the dependency: diff --git a/go.mod b/go.mod
index e0331c5..32db9e6 100644
--- a/go.mod
+++ b/go.mod
@@ -7,7 +7,7 @@ require (
github.com/blang/semver v3.5.1+incompatible // indirect
github.com/fatih/color v1.6.0 // indirect
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b // indirect
- github.com/gophercloud/gophercloud v0.0.0-20190215023200-9e57e2f8ff0c
+ github.com/gophercloud/gophercloud v0.0.0-20190216224116-dcc6e84aef1b
github.com/gophercloud/utils v0.0.0-20190212203534-6f24f46ce3c9
github.com/hashicorp/go-getter v0.0.0-20180425224130-3f60ec5cfbb2 // indirect
github.com/hashicorp/go-hclog v0.0.0-20180402200405-69ff559dc25f // indirect
diff --git a/go.sum b/go.sum
index 0b00872..f5e523b 100644
--- a/go.sum
+++ b/go.sum
@@ -82,8 +82,8 @@ github.com/googleapis/gax-go v0.0.0-20161107002406-da06d194a00e h1:CYRpN206UTHUi
github.com/googleapis/gax-go v0.0.0-20161107002406-da06d194a00e/go.mod h1:SFVmujtThgffbyetf+mdk2eWhX2bMyUtNHzFKcPA9HY=
github.com/gophercloud/gophercloud v0.0.0-20190208042652-bc37892e1968/go.mod h1:3WdhXV3rUYy9p6AUW8d94kr+HS62Y4VL9mBnFxsD8q4=
github.com/gophercloud/gophercloud v0.0.0-20190212181753-892256c46858/go.mod h1:vxM41WHh5uqHVBMZHzuwNOHh8XEoIEcSTewFxm1c5g8=
-github.com/gophercloud/gophercloud v0.0.0-20190215023200-9e57e2f8ff0c h1:n8bk/luCIxJX+0emWRexjWxuR4CRfMWQuAZYjzkq5Ck=
-github.com/gophercloud/gophercloud v0.0.0-20190215023200-9e57e2f8ff0c/go.mod h1:vxM41WHh5uqHVBMZHzuwNOHh8XEoIEcSTewFxm1c5g8=
+github.com/gophercloud/gophercloud v0.0.0-20190216224116-dcc6e84aef1b h1:bmCatXrA2OlbroyOV5gfpvtrgFV9H3lqr75lomgnusA=
+github.com/gophercloud/gophercloud v0.0.0-20190216224116-dcc6e84aef1b/go.mod h1:vxM41WHh5uqHVBMZHzuwNOHh8XEoIEcSTewFxm1c5g8=
github.com/gophercloud/utils v0.0.0-20190128072930-fbb6ab446f01/go.mod h1:wjDF8z83zTeg5eMLml5EBSlAhbF7G8DobyI1YsMuyzw=
github.com/gophercloud/utils v0.0.0-20190212203534-6f24f46ce3c9 h1:frK+RgSyzotPwHzxlbGO9aeM+zoQ4LgUfQbbynAAavw=
github.com/gophercloud/utils v0.0.0-20190212203534-6f24f46ce3c9/go.mod h1:95GkZLE4Nob0I9L4qW5dWmyiekLwK3HsVAOV13XY9CY=
diff --git a/vendor/modules.txt b/vendor/modules.txt
index 9574eec..8001978 100644
--- a/vendor/modules.txt
+++ b/vendor/modules.txt
@@ -58,7 +58,7 @@ github.com/golang/protobuf/ptypes
github.com/golang/protobuf/ptypes/any
github.com/golang/protobuf/ptypes/duration
github.com/golang/protobuf/ptypes/timestamp
-# github.com/gophercloud/gophercloud v0.0.0-20190215023200-9e57e2f8ff0c
+# github.com/gophercloud/gophercloud v0.0.0-20190216224116-dcc6e84aef1b
github.com/gophercloud/gophercloud
github.com/gophercloud/gophercloud/openstack
github.com/gophercloud/gophercloud/openstack/blockstorage/extensions/volumeactions |
I was pasting the commands as a reference - not that you did not already do them :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on gophercloud/gophercloud#1436