Keymanager V1: secrets resource #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anager_secret_metadata_v1
Removed secrets metadata resource from provider.go Fixed unit test that wasn't running Fixed unit test that wasn't running
Add content types to documentation
Avoid the "Conflict. Key in request is already in the secret metadata" error message after updating the imported secret with the metadata.
ghost
added
|
Build failed.
|
|
I successfully ran tests locally, though @jtopjian can you ask openlab team to enable barbican env variable ( |
|
Build succeeded.
|
|
@jtopjian @ozerovandrei @simonre ready for review |
|
Build failed.
|
|
Build failed.
|
|
Build succeeded.
|
|
@kayrus I created the issue openlab#324 but I don't think that we need to wait for them since you already tested those changes manually. What do you think? |
|
@ozerovandrei sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally written by @simonre
Fixes #352
Supersedes #650