Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute V2: Read flavor's ephemeral option #855

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Compute V2: Read flavor's ephemeral option #855

merged 1 commit into from
Sep 6, 2019

Conversation

kayrus
Copy link
Collaborator

@kayrus kayrus commented Sep 6, 2019

Resolves #852

@ghost ghost added the size/XS label Sep 6, 2019
@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 6, 2019

Build succeeded.

@kayrus
Copy link
Collaborator Author

kayrus commented Sep 6, 2019

@ozerovandrei ready for review

ozerovandrei
ozerovandrei requested changes Sep 6, 2019
View reviewed changes
Copy link
Member

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that we also need to set Computed: true for this attribute.

@kayrus
Copy link
Collaborator Author

kayrus commented Sep 6, 2019

@ozerovandrei good point, but If other elements doesn't have computed attribute (except extra_specs), why should ephemeral have it?

ozerovandrei
ozerovandrei approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's done intentionally because those values are usually set by the user.
Thank you!

@ozerovandrei ozerovandrei merged commit 64ae2a4 into terraform-provider-openstack:master Sep 6, 2019
@kayrus kayrus deleted the read-ephemeral branch September 7, 2019 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozerovandrei ozerovandrei ozerovandrei approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compute V2: Read flavor's ephemeral option
2 participants
@kayrus @ozerovandrei