-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data source for openstack_blockstorage_volume_v3 #947
Data source for openstack_blockstorage_volume_v3 #947
Conversation
…lockstorage_volume_v3 Feature/sre 593/openstack blockstorage volume v3
Build succeeded.
|
@@ -5,7 +5,6 @@ import ( | |||
"log" | |||
|
|||
"github.com/gophercloud/gophercloud/openstack/blockstorage/v2/volumes" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that we need this empty line given that we use it to separate terraform and gophercloud imports in other files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this file is unrelated to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine but change for imports in volume v2 datasource file shouldn't be there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some styling fixes, waiting for tests to finish.
I don't see any more issues so I'll merge this after successful tests run.
Build succeeded.
|
Thanks for that. Sorry I couldn't fix it sooner. |
Implements a new data source for openstack_blockstorage_volume_v3. Here is the related issue opened for it
#925