Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data source for openstack_blockstorage_volume_v3 #947

Merged

Conversation

Shonei
Copy link
Contributor

@Shonei Shonei commented Dec 18, 2019

Implements a new data source for openstack_blockstorage_volume_v3. Here is the related issue opened for it
#925

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 18, 2019

Build succeeded.

@@ -5,7 +5,6 @@ import (
"log"

"github.com/gophercloud/gophercloud/openstack/blockstorage/v2/volumes"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that we need this empty line given that we use it to separate terraform and gophercloud imports in other files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this file is unrelated to this PR.

Copy link
Member

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but change for imports in volume v2 datasource file shouldn't be there.

Copy link
Member

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some styling fixes, waiting for tests to finish.
I don't see any more issues so I'll merge this after successful tests run.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 20, 2019

Build succeeded.

@ozerovandrei ozerovandrei merged commit c4ee10d into terraform-provider-openstack:master Dec 20, 2019
@Shonei
Copy link
Contributor Author

Shonei commented Dec 20, 2019

I made some styling fixes, waiting for tests to finish.
I don't see any more issues so I'll merge this after successful tests run.

Thanks for that. Sorry I couldn't fix it sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants