Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_s3_bucket_inventory: Add support for 'IntelligentTieringAccessTier' #10746

Merged
merged 1 commit into from
Nov 15, 2019
Merged

r/aws_s3_bucket_inventory: Add support for 'IntelligentTieringAccessTier' #10746

merged 1 commit into from
Nov 15, 2019

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10743.

Release note for CHANGELOG:

resource/aws_s3_bucket_inventory: Add `IntelligentTieringAccessTier` as valid value for `optional_fields` attribute

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSS3BucketInventory_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSS3BucketInventory_ -timeout 120m
=== RUN   TestAccAWSS3BucketInventory_basic
=== PAUSE TestAccAWSS3BucketInventory_basic
=== RUN   TestAccAWSS3BucketInventory_encryptWithSSES3
=== PAUSE TestAccAWSS3BucketInventory_encryptWithSSES3
=== RUN   TestAccAWSS3BucketInventory_encryptWithSSEKMS
=== PAUSE TestAccAWSS3BucketInventory_encryptWithSSEKMS
=== CONT  TestAccAWSS3BucketInventory_basic
=== CONT  TestAccAWSS3BucketInventory_encryptWithSSEKMS
=== CONT  TestAccAWSS3BucketInventory_encryptWithSSES3
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSES3 (33.75s)
--- PASS: TestAccAWSS3BucketInventory_basic (34.30s)
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSEKMS (54.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	54.876s

@ewbankkit ewbankkit requested a review from a team November 5, 2019 01:39
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 5, 2019
@ewbankkit ewbankkit mentioned this pull request Nov 5, 2019
Merged
@bflad bflad mentioned this pull request Nov 15, 2019
Closed
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 15, 2019
@bflad bflad added this to the v2.37.0 milestone Nov 15, 2019
bflad
bflad approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks so much, @ewbankkit 🚀

Output from acceptance testing:

--- PASS: TestAccAWSS3BucketInventory_encryptWithSSES3 (27.93s)
--- PASS: TestAccAWSS3BucketInventory_basic (29.30s)
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSEKMS (50.53s)

aws/provider_test.go
@@ -161,6 +161,18 @@ func testAccCheckResourceAttrGlobalARN(resourceName, attributeName, arnService,
}
}

// testAccCheckResourceAttrGlobalARNNoAccount ensures the Terraform state exactly matches a formatted ARN without region or account ID
func testAccCheckResourceAttrGlobalARNNoAccount(resourceName, attributeName, arnService, arnResource string) resource.TestCheckFunc {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bflad bflad merged commit 581cc79 into hashicorp:master Nov 15, 2019
bflad added a commit that referenced this pull request Nov 15, 2019
@bflad
Update CHANGELOG for #10746
0c0f604
@ewbankkit ewbankkit deleted the issue-10743 branch November 18, 2019 08:25
@ghost
Copy link

ghost commented Nov 18, 2019

This has been released in version 2.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.37.0
Development

Successfully merging this pull request may close these issues.

Amazon S3 Inventory now reports the Intelligent-tiering access tier for objects
2 participants
@ewbankkit @bflad