resource/aws_codebuild_project: Implements git_submodules_config block #10952

jValdron · 2019-11-20T18:46:02Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource/aws_codebuild_project: Implements git_submodules_config block

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig
=== PAUSE TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig
=== CONT  TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig (30.38s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       30.409s
...

jValdron · 2019-11-20T19:27:37Z

Current CI build fails due to merged PR #9115

jValdron · 2019-11-20T19:51:25Z

Fixed with 4e449b0. a18727b created to kick off CI build. Not sure if there is a better way of re-triggering a build, sorry if that's not the proper way!

jValdron · 2020-01-02T20:28:16Z

This has been opened for a few weeks, I know it isn't a popular request or anything, but it is a very small change which would make the life of a few people a lot easier.

Anything that needs to be done in order to get this reviewed?

bflad

Hi @jValdron 👋 Thank you for submitting this. Overall its looking pretty good, just some testing and documentation adjustments and this should be good to merge. Please reach out if you have any questions or do not have time to implement the feedback items.

aws/resource_aws_codebuild_project.go

aws/resource_aws_codebuild_project_test.go

website/docs/r/codebuild_project.html.markdown

aws/resource_aws_codebuild_project_test.go

Adjusts hash values for CodeBuildProject/CodeCommit related test, adds a new test for GitSubmodulesConfig with Secondary Sources and a few nit fixes

jValdron · 2020-01-30T13:06:37Z

Hi @jValdron 👋 Thank you for submitting this. Overall its looking pretty good, just some testing and documentation adjustments and this should be good to merge. Please reach out if you have any questions or do not have time to implement the feedback items.

Thanks @bflad for taking the time to review this! :)

bflad

Looks great, thanks for those updates, @jValdron 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCodeBuildProject_ARMContainer (92.62s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier (47.04s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (66.34s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Location (192.93s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Name (52.07s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_NamespaceType (56.03s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName (131.45s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Packaging (43.52s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Path (83.45s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Type (52.39s)
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (43.37s)
--- PASS: TestAccAWSCodeBuildProject_basic (44.80s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (157.79s)
--- PASS: TestAccAWSCodeBuildProject_Cache (144.10s)
--- PASS: TestAccAWSCodeBuildProject_Description (80.83s)
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (62.33s)
--- PASS: TestAccAWSCodeBuildProject_Environment_Certificate (56.64s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable (133.92s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (69.10s)
--- PASS: TestAccAWSCodeBuildProject_Environment_RegistryCredential (46.80s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs (277.31s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_S3Logs (270.04s)
--- PASS: TestAccAWSCodeBuildProject_QueuedTimeout (55.61s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (52.52s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier (114.04s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled (50.52s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Location (55.77s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType (70.16s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName (46.25s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging (56.84s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Path (39.60s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Type (77.54s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (28.46s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig (94.98s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (64.49s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig (253.86s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (235.09s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket (93.96s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (116.11s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise (103.51s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (42.17s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (28.32s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (56.95s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (45.62s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSource (27.93s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid (11.59s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (85.86s)
--- PASS: TestAccAWSCodeBuildProject_Tags (102.04s)
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (144.61s)
--- PASS: TestAccAWSCodeBuildProject_WindowsContainer (51.60s)

ghost · 2020-02-07T01:37:02Z

This has been released in version 2.48.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ziemekobel-ef · 2020-02-24T12:14:12Z

aws/resource_aws_codebuild_project.go

@@ -1000,6 +1026,21 @@ func expandProjectSourceData(data map[string]interface{}) codebuild.ProjectSourc
 		}
 	}

+	// Only valid for CODECOMMIT source types.
+	if sourceType == codebuild.SourceTypeCodecommit {


Why is it valid only for Codecommit and not for other providers? It does work for us with GitHub when we set it manually (not through Terraform).

No specific reason except that for some reason, I thought it was only valid for CodeCommit. Not sure where I thought I had seen that, but clearly should work with everything. AWS docs doesn't seem to have anything mentioning that it should be CodeCommit only.

Seeing as this has been merged, and released, I'm not sure what is the best way forward to resolve this.

ghost · 2020-03-02T14:50:29Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

Adds GitSubmodulesConfig support for CodeBuild

e8d5b0e

jValdron requested a review from a team November 20, 2019 18:46

Re-running CI after un-related PR broke CI builds, CI fixed in 4e449b0

a18727b

bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 29, 2020

bflad suggested changes Jan 29, 2020

View reviewed changes

Changes suggested by @bflad in PR #10952; tests cases/nit fixes

051425d

Adjusts hash values for CodeBuildProject/CodeCommit related test, adds a new test for GitSubmodulesConfig with Secondary Sources and a few nit fixes

ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jan 30, 2020

jValdron requested a review from bflad January 30, 2020 13:05

bflad added this to the v2.48.0 milestone Jan 31, 2020

bflad approved these changes Jan 31, 2020

View reviewed changes

bflad merged commit 32ff704 into hashicorp:master Jan 31, 2020

bflad added a commit that referenced this pull request Jan 31, 2020

Update CHANGELOG for #10952

fad205b

jValdron deleted the codebuild-gitsubmodules branch February 3, 2020 17:35

ziemekobel-ef reviewed Feb 24, 2020

View reviewed changes

ghost locked and limited conversation to collaborators Mar 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resource/aws_codebuild_project: Implements git_submodules_config block #10952

resource/aws_codebuild_project: Implements git_submodules_config block #10952

jValdron commented Nov 20, 2019

jValdron commented Nov 20, 2019

jValdron commented Nov 20, 2019 •

edited

Loading

jValdron commented Jan 2, 2020

bflad left a comment

jValdron commented Jan 30, 2020

bflad left a comment

ghost commented Feb 7, 2020

ziemekobel-ef Feb 24, 2020

jValdron Feb 24, 2020

ghost commented Mar 2, 2020

resource/aws_codebuild_project: Implements git_submodules_config block #10952

resource/aws_codebuild_project: Implements git_submodules_config block #10952

Conversation

jValdron commented Nov 20, 2019

Community Note

jValdron commented Nov 20, 2019

jValdron commented Nov 20, 2019 • edited Loading

jValdron commented Jan 2, 2020

bflad left a comment

Choose a reason for hiding this comment

jValdron commented Jan 30, 2020

bflad left a comment

Choose a reason for hiding this comment

ghost commented Feb 7, 2020

ziemekobel-ef Feb 24, 2020

Choose a reason for hiding this comment

jValdron Feb 24, 2020

Choose a reason for hiding this comment

ghost commented Mar 2, 2020

jValdron commented Nov 20, 2019 •

edited

Loading