Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/api_gateway_rest_api - add attributes #10971

Merged
merged 4 commits into from
Feb 11, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Nov 21, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688

Release note for CHANGELOG:

- data/data_source_api_gateway_rest_api: Add `tags`, `arn`, `description`, `policy`, `api_key_source`, `minimum_compression_size`, `binary_media_types`, `endpoint_configuration` and `execution_arn` attributes

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAwsApiGatewayRestApi'
--- PASS: TestAccDataSourceAwsApiGatewayRestApi (111.73s)

@DrFaust92 DrFaust92 requested a review from a team November 21, 2019 16:25
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 21, 2019
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Feb 4, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 10, 2020
@bflad bflad self-assigned this Feb 10, 2020
@bflad bflad added this to the v2.49.0 milestone Feb 11, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks so much, @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsApiGatewayRestApi (8.90s)

},
},
},
"execution_arn": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New attribute is missing documentation, will add on merge.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, this happened to me more than once and got me thinking if we can have some sort of validation for this with a linter. ill take a look if i can hack something.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its partially possible today, but requires the output of terraform providers schema -json, which is not PR friendly without some Terraform CLI and plugin directory setup in CI. We're hoping to allow the provider binary to output its own form of that JSON instead (with all data; Terraform core does not receive the full schema information from providers) to remove the Terraform CLI and ancillary setup, but that's likely a few weeks out.

I have some centralized tooling issues available here (bflad/tfproviderdocs#15 / bflad/tfproviderdocs#16), but we'd likely also want Markdown AST parsing in that tooling (rather than regular expressions, for example) before implementing a lot of the Markdown checking to prevent false positives.

@bflad bflad merged commit 952e7ac into hashicorp:master Feb 11, 2020
bflad added a commit that referenced this pull request Feb 11, 2020
… add missing execution_arn attribute

Reference: #10971
@ghost
Copy link

ghost commented Feb 14, 2020

This has been released in version 2.49.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants