Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: support Route53 Traffic Policies #11256

Closed
knksmith57 opened this issue Dec 11, 2019 · 8 comments · Fixed by #23602
Closed

feature request: support Route53 Traffic Policies #11256

knksmith57 opened this issue Dec 11, 2019 · 8 comments · Fixed by #23602
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. new-resource Introduces a new resource. service/route53 Issues and PRs that pertain to the route53 service.
Milestone

Comments

@knksmith57
Copy link

knksmith57 commented Dec 11, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Traffic Policies are groups of rules and endpoints expressed as a single document that create multiple Resource Record Sets. Traffic Policies are reusable and are attached to Hosted Zones using Traffic Policy Instances. Traffic Policies are immutable and automatically versioned.

New or Affected Resource(s)

  • aws_route53_traffic_policy
  • aws_route53_traffic_policy_document
  • aws_route53_traffic_policy_instance

Potential Terraform Configuration

data "aws_route53_traffic_policy_document" "example" {
  record_type = "A"
  start_rule  = "site_switch"

  endpoint {
    id    = "my_elb"
    type  = "elastic-load-balancer"
    value = "elb-111111.us-east-1.elb.amazonaws.com"
  }

  endpoint {
    id     = "site_down_banner"
    type   = "s3-website"
    region = "us-east-1"
    value  = "www.example.com"
  }

  rule {
    id   = "site_switch"
    type = "failover"
    primary = {
      endpoint_reference = "my_elb"
    }
    secondary = {
      endpoint_reference = "site_down_banner"
    }
  }
}

resource "aws_route53_zone" "main" {
  name = "test.com"
}

resource "aws_route53_traffic_policy" "www" {
  name     = "www"
  document = "${data.aws_route53_traffic_policy_document.example.json}"
}

resource "aws_route53_traffic_policy_instance" "www_main" {
  zone_id        = "${aws_route53_zone.main.zone_id}"
  name           = "${aws_route53_traffic_policy.www.name}_${aws_route53_zone.main.name}"
  policy_id      = "${aws_route53_traffic_policy.www.id}"
  policy_version = "${aws_route53_traffic_policy.www.version}"
}

References

@knksmith57 knksmith57 added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 11, 2019
@ghost ghost added the service/route53 Issues and PRs that pertain to the route53 service. label Dec 11, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 11, 2019
@knksmith57
Copy link
Author

/cc @thetwoj

@myakubiv-solringair
Copy link

Hi! are there any plans on implementing this?
thanks

@mwieczorek
Copy link
Contributor

Hi. I started to work on aws_route53_traffic_policy, but cannot provide any date when will be ready (not much time I can spend on this).

Sidenote: I hit an issue with GetTrafficPolicy - it returns data even for deleted traffic policies - I asked AWS support if it's expected behavior and waiting for a reply (I know I can use ListTrafficPolicies and iterate to check but I prefer to make it clear which one should be used and why)

@anGie44 anGie44 added new-data-source Introduces a new data source. new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 2, 2021
@crablab
Copy link

crablab commented Apr 22, 2021

Do we have any updates on this? 👀 We're using a manual workaround outside of Tf as this isn't supported.

@rym-dd
Copy link

rym-dd commented Jun 9, 2021

Hi, are there updates about this? Thanks.

@ewbankkit
Copy link
Contributor

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

@github-actions github-actions bot added this to the v4.7.0 milestone Mar 22, 2022
@github-actions
Copy link

This functionality has been released in v4.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 6, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. new-resource Introduces a new resource. service/route53 Issues and PRs that pertain to the route53 service.
Projects
None yet
7 participants