add support for private ipv4 addresses in subnet mapping of ELB V2 #11404

ghost · 2019-12-22T02:37:24Z

Please let me know if there's anything else I should update, this is my first PR to terraform-provider-aws. I've tested this feature by creating an aws_lb like the example below. I've verified that the subnet mapping in the aws console shows the private ipv4 address.

steps to test;

provider "aws" {
  region  = "us-east-1"
  profile = "default"
}

resource "aws_vpc" "test" {
  cidr_block = "10.0.0.0/20"

  tags = {
    Name = "test-vpc"
  }
}

resource "aws_subnet" "test" {
  vpc_id     = "${aws_vpc.test.id}"
  cidr_block = "10.0.1.0/24"

  tags = {
    Name = "test-subnet"
  }
}

resource "aws_lb" "test" {
  name               = "test-lb-tf"
  internal           = true
  load_balancer_type = "network"
  subnet_mapping {
    subnet_id            = aws_subnet.test.id
    private_ipv4_address = "10.0.1.15"
  }
}

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

fixes #11403
fixes #11044

Release note for CHANGELOG:

add support for private ipv4 address in subnet mappings of resource aws_lb

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSLB_NLB_privateipv4address'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLB_NLB_privateipv4address -timeout 120m
=== RUN   TestAccAWSLB_NLB_privateipv4address
=== PAUSE TestAccAWSLB_NLB_privateipv4address
=== CONT  TestAccAWSLB_NLB_privateipv4address
--- PASS: TestAccAWSLB_NLB_privateipv4address (228.60s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       228.635s

ewbankkit · 2019-12-22T12:14:38Z

Closes #11044.
Closes #11887.
Closes #11403.

cSNiHab · 2020-01-21T16:00:35Z

Hi, we're currently deciding if we should wait for this PR to be merged or if we should implement a null_resource workaround to get private static IPs in.

Could you give us an indication if this PR will be merged? (and if so, are there any timelines?)

ghost · 2020-01-25T23:51:56Z

Currently awaiting maintainer review.

TimJDFletcher · 2020-03-16T15:22:33Z

We have just run in this problem during a roll out of access to our on-premise resources from AWS.

Any news from the code review on this?

ghost · 2020-03-21T18:12:55Z

We have just run in this problem during a roll out of access to our on-premise resources from AWS.

Any news from the code review on this?

@bflad

florianlocqueneux · 2020-04-01T10:13:30Z

Hello,
Any chance to get this reviewed ?
It could be really helpfull to get this merged.

website/docs/r/lb.html.markdown

bmathieu33 · 2020-04-22T10:11:22Z

Should this PR also mark #3007 as closed?

ewbankkit · 2020-04-22T10:52:12Z

@bmathieu33 It looks like #3007 is more related to #2901 / #11000 but given the decision on that solution, yes it should probably be closed (it does contain a lot of great workarounds but will still be searchable). Thanks.

mohamed-rekiba · 2020-04-28T10:29:00Z

is there any timelines for this feature?

florianlocqueneux · 2020-04-28T17:09:12Z

This improvement would be really welcome here :)
Any visibility on the timeline would help as well.
Thank you so much

florianlocqueneux · 2020-05-11T12:26:30Z

Hi @kadenlnelson , unfortunately, your last commit is not successful.

dthvt · 2020-05-12T00:19:37Z

The CI job is not particularly forthcoming w/ the root cause of the failure. Is it because the = signs aren't aligned in the documentation HCL snippet? That's about the only thing I can see that looks like it might be a lint failure.

…ivate-ipv4-address

DrFaust92

Hey @kadenlnelson,
thanks for submitting this, a few comments to shorten the review cycle by mainteners when they get to this

DrFaust92 · 2020-06-14T20:28:01Z

aws/resource_aws_lb.go

+						"private_ipv4_address": {
+							Type:     schema.TypeString,
+							Optional: true,
+							ForceNew: true,


add validation here ValidateFunc: validation.IsIPv4Address,

DrFaust92 · 2020-06-14T20:31:43Z

aws/resource_aws_lb_test.go

+			{
+				Config: testAccAWSLBConfig_networkLoadBalancerPrivateIPV4Address(lbName),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					testAccCheckAWSLBExists(resourceName, &conf),


most of these check are irrelevant to the specific case, lets leave only the relevant check

resource.TestCheckResourceAttr(resourceName, "internal", "true"), resource.TestCheckResourceAttr(resourceName, "load_balancer_type", "network"), resource.TestCheckResourceAttr(resourceName, "subnet_mapping.#", "1"),

DrFaust92 · 2020-06-14T20:32:34Z

aws/resource_aws_lb_test.go

+					resource.TestCheckResourceAttrSet(resourceName, "zone_id"),
+					resource.TestCheckResourceAttr(resourceName, "subnet_mapping.#", "1"),
+				),
+			},


add import step:

{ ResourceName: resourceName, ImportState: true, ImportStateVerify: true, },

DrFaust92 · 2020-06-14T20:34:41Z

aws/resource_aws_lb_test.go

+  vpc_id                  = "${aws_vpc.alb_test.id}"
+  cidr_block              = "10.10.0.0/21"
+  map_public_ip_on_launch = true
+  availability_zone       = "us-west-2a"


to make test region agnostic and to avoid environment specific failures, can please add the following to the test config:

data "aws_availability_zones" "available" { state = "available" filter { name = "opt-in-status" values = ["opt-in-not-required"] } }

and change the hardcoded az to "${data.aws_availability_zones.available.names[0]}"

DrFaust92 · 2020-06-14T20:49:40Z

also Closes #11674

bflad

Hi @kadenlnelson 👋 Thank you for submitting this and apologies for the long review cycle. Overall this is looking really good, once you address @DrFaust92's review items we should be able to get this in. Please reach out with any questions or if you do not have time to implement them.

abohne · 2020-07-10T21:21:45Z

@kadenlnelson Are you able to make the requested changes?

Floble · 2020-07-16T14:21:33Z

Any progress on this? Is there an approximate time schedule indicating when to expect the merge? We would appreciate this solution.

bflad · 2020-07-16T14:49:56Z

The maintainers are actively working on the 3.0 major release for the next week or two, then this is up for final review. If we do not see updates from @kadenlnelson to adjust the requested changes in the meantime, we will make the changes on top of this contribution to merge it in for release in 3.1.

bflad

After fixing the merge conflict and addressing @DrFaust92's feedback (thanks!), looks good to me 🚀

Output from acceptance testing:

--- PASS: TestAccAWSLB_ALB_AccessLogs (336.66s)
--- PASS: TestAccAWSLB_ALB_AccessLogs_Prefix (303.22s)
--- PASS: TestAccAWSLB_ALB_basic (213.75s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateDeletionProtection (290.62s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateDropInvalidHeaderFields (287.40s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateHttp2 (318.53s)
--- PASS: TestAccAWSLB_BackwardsCompatibility (220.15s)
--- PASS: TestAccAWSLB_generatedName (203.47s)
--- PASS: TestAccAWSLB_generatesNameForZeroValue (205.38s)
--- PASS: TestAccAWSLB_namePrefix (193.39s)
--- PASS: TestAccAWSLB_networkLoadbalancer_subnet_change (260.37s)
--- PASS: TestAccAWSLB_networkLoadbalancer_updateCrossZone (323.38s)
--- PASS: TestAccAWSLB_networkLoadbalancerEIP (269.79s)
--- PASS: TestAccAWSLB_NLB_AccessLogs (414.90s)
--- PASS: TestAccAWSLB_NLB_AccessLogs_Prefix (380.57s)
--- PASS: TestAccAWSLB_NLB_basic (256.98s)
--- PASS: TestAccAWSLB_NLB_privateipv4address (252.14s)
--- PASS: TestAccAWSLB_noSecurityGroup (275.40s)
--- PASS: TestAccAWSLB_tags (274.26s)
--- PASS: TestAccAWSLB_updatedIpAddressType (234.58s)
--- PASS: TestAccAWSLB_updatedSecurityGroups (233.02s)
--- PASS: TestAccAWSLB_updatedSubnets (263.78s)

Reference: #11404 (review) Output from acceptance testing: ``` --- PASS: TestAccAWSLB_ALB_AccessLogs (336.66s) --- PASS: TestAccAWSLB_ALB_AccessLogs_Prefix (303.22s) --- PASS: TestAccAWSLB_ALB_basic (213.75s) --- PASS: TestAccAWSLB_applicationLoadBalancer_updateDeletionProtection (290.62s) --- PASS: TestAccAWSLB_applicationLoadBalancer_updateDropInvalidHeaderFields (287.40s) --- PASS: TestAccAWSLB_applicationLoadBalancer_updateHttp2 (318.53s) --- PASS: TestAccAWSLB_BackwardsCompatibility (220.15s) --- PASS: TestAccAWSLB_generatedName (203.47s) --- PASS: TestAccAWSLB_generatesNameForZeroValue (205.38s) --- PASS: TestAccAWSLB_namePrefix (193.39s) --- PASS: TestAccAWSLB_networkLoadbalancer_subnet_change (260.37s) --- PASS: TestAccAWSLB_networkLoadbalancer_updateCrossZone (323.38s) --- PASS: TestAccAWSLB_networkLoadbalancerEIP (269.79s) --- PASS: TestAccAWSLB_NLB_AccessLogs (414.90s) --- PASS: TestAccAWSLB_NLB_AccessLogs_Prefix (380.57s) --- PASS: TestAccAWSLB_NLB_basic (256.98s) --- PASS: TestAccAWSLB_NLB_privateipv4address (252.14s) --- PASS: TestAccAWSLB_noSecurityGroup (275.40s) --- PASS: TestAccAWSLB_tags (274.26s) --- PASS: TestAccAWSLB_updatedIpAddressType (234.58s) --- PASS: TestAccAWSLB_updatedSecurityGroups (233.02s) --- PASS: TestAccAWSLB_updatedSubnets (263.78s) ```

ghost · 2020-08-07T23:31:33Z

This has been released in version 3.1.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

TimJDFletcher · 2020-08-10T13:26:50Z

We have just upgraded to the aws provider version 3.1 to try and use this functionality.

We are now getting the following errors at the plan stage:

Error: error setting subnet_mapping: Invalid address to set: []string{"subnet_mapping", "0", "private_ipv4_address"}

I believe it could be related to this type of bug: #4986

Should I open a new bug for this?

Edit thinking about this a little more I wonder if this only impacts NLBs with pinned IPs?

We create the NLBs via the aws cli and then use a data lookup to find the ARN to configure them.

bflad · 2020-08-10T16:40:23Z

@TimJDFletcher yes please create a new bug report. Thanks.

ghost · 2020-08-30T17:10:56Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

add support for private ipv4 addresses in subnet mapping

a1c1148

ghost self-requested a review December 22, 2019 02:37

ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Dec 22, 2019

Add documentation changes

59620e6

ghost added documentation Introduces or discusses updates to documentation. size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 25, 2019

bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 2, 2020

ewbankkit mentioned this pull request Mar 21, 2020

Support manually providing a private IPv4 address for an internal network load balancer #12331

Closed

ernstvonoelsen reviewed Apr 17, 2020

View reviewed changes

website/docs/r/lb.html.markdown Outdated Show resolved Hide resolved

ernstvonoelsen reviewed Apr 17, 2020

View reviewed changes

website/docs/r/lb.html.markdown Outdated Show resolved Hide resolved

This was referenced Apr 21, 2020

Add private_ips attribute to aws_lb resource #2901

Closed

Add private_ips attribute to aws_lb resource #11000

Closed

maryelizbeth mentioned this pull request Apr 22, 2020

Export private IPs/ENIs of internal NLBs as attributes on the resource #3007

Closed

typo fix

fcd1ab8

Merge remote-tracking branch 'upstream/master' into subnet-mapping-pr…

f3d6bbe

…ivate-ipv4-address

DrFaust92 suggested changes Jun 14, 2020

View reviewed changes

ghost requested a review from DrFaust92 June 14, 2020 21:43

bflad self-assigned this Jun 24, 2020

bflad removed the needs-triage Waiting for first response or review from a maintainer. label Jun 24, 2020

bflad suggested changes Jun 24, 2020

View reviewed changes

bflad added this to the v2.68.0 milestone Jun 24, 2020

breathingdust modified the milestones: v2.68.0, v2.69.0 Jun 25, 2020

anGie44 force-pushed the master branch from 6c6566f to 081bf57 Compare June 29, 2020 16:14

breathingdust modified the milestones: v2.69.0, v2.70.0, v3.1.0 Jul 2, 2020

bflad approved these changes Jul 31, 2020

View reviewed changes

bflad added a commit that referenced this pull request Jul 31, 2020

Update CHANGELOG for #11404

10bc041

bflad merged commit 2a71545 into hashicorp:master Jul 31, 2020

DrFaust92 mentioned this pull request Aug 10, 2020

d/lb - add private_ipv4_address attribute to subnet mapping #14545

Merged

hashicorp locked and limited conversation to collaborators Aug 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add support for private ipv4 addresses in subnet mapping of ELB V2 #11404

add support for private ipv4 addresses in subnet mapping of ELB V2 #11404

ghost commented Dec 22, 2019 •

edited by ghost

ewbankkit commented Dec 22, 2019 •

edited

cSNiHab commented Jan 21, 2020 •

edited

ghost commented Jan 25, 2020

TimJDFletcher commented Mar 16, 2020

ghost commented Mar 21, 2020

florianlocqueneux commented Apr 1, 2020 •

edited

bmathieu33 commented Apr 22, 2020

ewbankkit commented Apr 22, 2020

mohamed-rekiba commented Apr 28, 2020

florianlocqueneux commented Apr 28, 2020

florianlocqueneux commented May 11, 2020

dthvt commented May 12, 2020

DrFaust92 left a comment •

edited

DrFaust92 Jun 14, 2020

DrFaust92 Jun 14, 2020

DrFaust92 Jun 14, 2020

DrFaust92 Jun 14, 2020

DrFaust92 commented Jun 14, 2020

bflad left a comment

abohne commented Jul 10, 2020

Floble commented Jul 16, 2020

bflad commented Jul 16, 2020

bflad left a comment

ghost commented Aug 7, 2020

TimJDFletcher commented Aug 10, 2020 •

edited

bflad commented Aug 10, 2020

ghost commented Aug 30, 2020

add support for private ipv4 addresses in subnet mapping of ELB V2 #11404

add support for private ipv4 addresses in subnet mapping of ELB V2 #11404

Conversation

ghost commented Dec 22, 2019 • edited by ghost

steps to test;

Community Note

ewbankkit commented Dec 22, 2019 • edited

cSNiHab commented Jan 21, 2020 • edited

ghost commented Jan 25, 2020

TimJDFletcher commented Mar 16, 2020

ghost commented Mar 21, 2020

florianlocqueneux commented Apr 1, 2020 • edited

bmathieu33 commented Apr 22, 2020

ewbankkit commented Apr 22, 2020

mohamed-rekiba commented Apr 28, 2020

florianlocqueneux commented Apr 28, 2020

florianlocqueneux commented May 11, 2020

dthvt commented May 12, 2020

DrFaust92 left a comment • edited

Choose a reason for hiding this comment

DrFaust92 Jun 14, 2020

Choose a reason for hiding this comment

DrFaust92 Jun 14, 2020

Choose a reason for hiding this comment

DrFaust92 Jun 14, 2020

Choose a reason for hiding this comment

DrFaust92 Jun 14, 2020

Choose a reason for hiding this comment

DrFaust92 commented Jun 14, 2020

bflad left a comment

Choose a reason for hiding this comment

abohne commented Jul 10, 2020

Floble commented Jul 16, 2020

bflad commented Jul 16, 2020

bflad left a comment

Choose a reason for hiding this comment

ghost commented Aug 7, 2020

TimJDFletcher commented Aug 10, 2020 • edited

bflad commented Aug 10, 2020

ghost commented Aug 30, 2020

ghost commented Dec 22, 2019 •

edited by ghost

ewbankkit commented Dec 22, 2019 •

edited

cSNiHab commented Jan 21, 2020 •

edited

florianlocqueneux commented Apr 1, 2020 •

edited

DrFaust92 left a comment •

edited

TimJDFletcher commented Aug 10, 2020 •

edited