Direct Connect virtual interface resources: Refactor tagging logic to keyvaluetags package and add 'amazon_side_asn' attribute

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688.
Closes #11350,
Relates #11330.

Release note for CHANGELOG:

resource/aws_dx_hosted_private_virtual_interface: Add `amazon_side_asn` attribute
resource/aws_dx_hosted_public_virtual_interface: Add `amazon_side_asn` attribute
resource/aws_dx_hosted_transit_virtual_interface: Add `amazon_side_asn` attribute
resource/aws_dx_private_virtual_interface: Add `amazon_side_asn` attribute
resource/aws_dx_public_virtual_interface: Add `amazon_side_asn` attribute
resource/aws_dx_transit_virtual_interface: Add `amazon_side_asn` attribute

Output from acceptance testing:

$ DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxPrivateVirtualInterface'
$ AWS_ALTERNATE_PROFILE=pppppppp DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxHostedPrivateVirtualInterface'
$ DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxPublicVirtualInterface'
$ AWS_ALTERNATE_PROFILE=pppppppp DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxHostedPublicVirtualInterface'
$ DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxTransitVirtualInterface'
$ AWS_ALTERNATE_PROFILE=pppppppp DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxHostedTransitVirtualInterface'

[ewbankkit]

I no longer have permissions to be able to run these acceptance tests.
@ryno75 @devonbleak Are you able to run these acceptance tests?Thanks.

[ryno75]

I no longer have permissions to be able to run these acceptance tests.
@ryno75 @devonbleak Are you able to run these acceptance tests?Thanks.

wow... I'm delinquent on my github email! Let me see if I can do the needful.

[ryno75]

I had to delete a transit VIF in my staging env but... finally got it done.
actual dxcon ID redacted...

$ DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxPrivateVirtualInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAwsDxPrivateVirtualInterface -timeout 120m
go: downloading github.com/aws/aws-sdk-go v1.26.5
go: extracting github.com/aws/aws-sdk-go v1.26.5
go: finding github.com/aws/aws-sdk-go v1.26.5
=== RUN   TestAccAwsDxPrivateVirtualInterface_basic
=== PAUSE TestAccAwsDxPrivateVirtualInterface_basic
=== RUN   TestAccAwsDxPrivateVirtualInterface_Tags
=== PAUSE TestAccAwsDxPrivateVirtualInterface_Tags
=== RUN   TestAccAwsDxPrivateVirtualInterface_DxGateway
=== PAUSE TestAccAwsDxPrivateVirtualInterface_DxGateway
=== CONT  TestAccAwsDxPrivateVirtualInterface_basic
=== CONT  TestAccAwsDxPrivateVirtualInterface_Tags
=== CONT  TestAccAwsDxPrivateVirtualInterface_DxGateway
--- PASS: TestAccAwsDxPrivateVirtualInterface_Tags (362.33s)
--- PASS: TestAccAwsDxPrivateVirtualInterface_DxGateway (378.47s)
--- PASS: TestAccAwsDxPrivateVirtualInterface_basic (686.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	687.505s

$ AWS_ALTERNATE_PROFILE=ietest.admin DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxHostedPrivateVirtualInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAwsDxHostedPrivateVirtualInterface -timeout 120m
=== RUN   TestAccAwsDxHostedPrivateVirtualInterface_basic
=== PAUSE TestAccAwsDxHostedPrivateVirtualInterface_basic
=== RUN   TestAccAwsDxHostedPrivateVirtualInterface_AccepterTags
=== PAUSE TestAccAwsDxHostedPrivateVirtualInterface_AccepterTags
=== CONT  TestAccAwsDxHostedPrivateVirtualInterface_basic
=== CONT  TestAccAwsDxHostedPrivateVirtualInterface_AccepterTags
--- PASS: TestAccAwsDxHostedPrivateVirtualInterface_basic (375.72s)
--- PASS: TestAccAwsDxHostedPrivateVirtualInterface_AccepterTags (377.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	377.661s

$ DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxPublicVirtualInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAwsDxPublicVirtualInterface -timeout 120m
=== RUN   TestAccAwsDxPublicVirtualInterface_basic
=== PAUSE TestAccAwsDxPublicVirtualInterface_basic
=== RUN   TestAccAwsDxPublicVirtualInterface_Tags
=== PAUSE TestAccAwsDxPublicVirtualInterface_Tags
=== CONT  TestAccAwsDxPublicVirtualInterface_basic
=== CONT  TestAccAwsDxPublicVirtualInterface_Tags
--- PASS: TestAccAwsDxPublicVirtualInterface_basic (41.57s)
--- PASS: TestAccAwsDxPublicVirtualInterface_Tags (53.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	53.885s

$ AWS_ALTERNATE_PROFILE=ietest.admin DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxHostedPublicVirtualInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAwsDxHostedPublicVirtualInterface -timeout 120m
=== RUN   TestAccAwsDxHostedPublicVirtualInterface_basic
=== PAUSE TestAccAwsDxHostedPublicVirtualInterface_basic
=== RUN   TestAccAwsDxHostedPublicVirtualInterface_AccepterTags
=== PAUSE TestAccAwsDxHostedPublicVirtualInterface_AccepterTags
=== CONT  TestAccAwsDxHostedPublicVirtualInterface_basic
=== CONT  TestAccAwsDxHostedPublicVirtualInterface_AccepterTags
--- PASS: TestAccAwsDxHostedPublicVirtualInterface_basic (59.00s)
--- PASS: TestAccAwsDxHostedPublicVirtualInterface_AccepterTags (68.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	69.544s

$  DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxTransitVirtualInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAwsDxTransitVirtualInterface -timeout 120m
=== RUN   TestAccAwsDxTransitVirtualInterface
=== RUN   TestAccAwsDxTransitVirtualInterface/tags
=== RUN   TestAccAwsDxTransitVirtualInterface/basic
--- PASS: TestAccAwsDxTransitVirtualInterface (1490.07s)
    --- PASS: TestAccAwsDxTransitVirtualInterface/tags (543.57s)
    --- PASS: TestAccAwsDxTransitVirtualInterface/basic (946.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1490.662s

$ AWS_ALTERNATE_PROFILE=ietest.admin DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxHostedTransitVirtualInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAwsDxHostedTransitVirtualInterface -timeout 120m
=== RUN   TestAccAwsDxHostedTransitVirtualInterface
=== RUN   TestAccAwsDxHostedTransitVirtualInterface/basic
=== RUN   TestAccAwsDxHostedTransitVirtualInterface/accepterTags
--- PASS: TestAccAwsDxHostedTransitVirtualInterface (1085.80s)
    --- PASS: TestAccAwsDxHostedTransitVirtualInterface/basic (446.07s)
    --- PASS: TestAccAwsDxHostedTransitVirtualInterface/accepterTags (639.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1086.423s

[bflad]

Thanks so much @ryno75 for the testing assistance and @ewbankkit for the implementation. Merging on community review process for Direct Connect resources. 🚀

[ghost]

This has been released in version 2.51.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!