Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable RDS MSSQL agent log export to CloudWatch #11472

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

owenfarrell
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11361

Release note for CHANGELOG:

Added support for exporting MSSQL agent logs from RDS to CloudWatch

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL
=== PAUSE TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL
=== CONT  TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL (761.95s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       763.309s
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap      0.154s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags 0.125s [no tests to run]

@owenfarrell owenfarrell requested a review from a team January 3, 2020 20:01
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 3, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 10, 2020
@bflad bflad self-assigned this Feb 10, 2020
@bflad bflad added this to the v2.49.0 milestone Feb 11, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks so much for this, @owenfarrell 🚀

Output from acceptance testing:

--- PASS: TestAccAWSDBInstance_AllowMajorVersionUpgrade (474.61s)
--- PASS: TestAccAWSDBInstance_basic (438.41s)
--- PASS: TestAccAWSDBInstance_CACertificateIdentifier (679.67s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfiguration (547.75s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfigurationUpdate (788.47s)
--- PASS: TestAccAWSDBInstance_DeletionProtection (554.80s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL (736.90s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (696.48s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (523.83s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier (781.94s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier_SkipFinalSnapshot (952.56s)
--- PASS: TestAccAWSDBInstance_generatedName (478.17s)
--- PASS: TestAccAWSDBInstance_iamAuth (498.07s)
--- PASS: TestAccAWSDBInstance_IsAlreadyBeingDeleted (530.06s)
--- PASS: TestAccAWSDBInstance_kmsKey (456.32s)
--- PASS: TestAccAWSDBInstance_MaxAllocatedStorage (584.32s)
--- PASS: TestAccAWSDBInstance_MinorVersion (462.41s)
--- PASS: TestAccAWSDBInstance_MonitoringInterval (1092.87s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToDisabled (736.51s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToRemoved (855.12s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_RemovedToEnabled (700.90s)
--- PASS: TestAccAWSDBInstance_MSSQL_Domain (3427.69s)
--- PASS: TestAccAWSDBInstance_MSSQL_DomainSnapshotRestore (3079.73s)
--- PASS: TestAccAWSDBInstance_MSSQL_TZ (2060.36s)
--- PASS: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (1980.37s)
--- PASS: TestAccAWSDBInstance_namePrefix (478.39s)
--- PASS: TestAccAWSDBInstance_optionGroup (539.04s)
--- PASS: TestAccAWSDBInstance_Password (582.66s)
--- PASS: TestAccAWSDBInstance_portUpdate (548.74s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb (1702.61s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllocatedStorage (1965.53s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllowMajorVersionUpgrade (1482.29s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AutoMinorVersionUpgrade (1408.80s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AvailabilityZone (1685.48s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupRetentionPeriod (1864.36s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupWindow (1676.89s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_CACertificateIdentifier (1656.48s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_IamDatabaseAuthenticationEnabled (1576.55s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaintenanceWindow (1636.90s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaxAllocatedStorage (1545.99s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Monitoring (1619.20s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MultiAZ (2132.46s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_ParameterGroupName (1788.60s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_PerformanceInsightsEnabled (1747.22s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Port (1495.18s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_VpcSecurityGroupIds (1416.62s)
--- PASS: TestAccAWSDBInstance_separate_iops_update (852.20s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier (1332.26s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllocatedStorage (1655.33s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllowMajorVersionUpgrade (2000.12s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AutoMinorVersionUpgrade (1231.52s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AvailabilityZone (1243.41s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod (1282.01s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod_Unset (1625.37s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupWindow (1292.35s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DeletionProtection (1338.01s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_IamDatabaseAuthenticationEnabled (1452.97s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Io1Storage (1514.70s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaintenanceWindow (1301.24s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaxAllocatedStorage (1120.91s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1516.06s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ (2083.15s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ_SQLServer (4670.84s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_ParameterGroupName (1211.29s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_PerformanceInsightsEnabled (1513.98s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Port (1170.43s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Tags (1231.22s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds (1212.77s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds_Tags (1153.32s)
--- PASS: TestAccAWSDBInstance_subnetGroup (1014.89s)
--- PASS: TestAccAWSRDSDBInstance_PerformanceInsightsEnabled_DisabledToEnabled (650.95s)
--- PASS: TestAccAWSRDSDBInstance_PerformanceInsightsEnabled_EnabledToDisabled (832.81s)
--- PASS: TestAccAWSRDSDBInstance_PerformanceInsightsKmsKeyId (894.27s)
--- PASS: TestAccAWSRDSDBInstance_PerformanceInsightsRetentionPeriod (812.56s)

@bflad bflad merged commit edee255 into hashicorp:master Feb 11, 2020
bflad added a commit that referenced this pull request Feb 11, 2020
@ghost
Copy link

ghost commented Feb 14, 2020

This has been released in version 2.49.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Agent cloudwatch log exports for RDS
2 participants