Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gamelift fleet tagging support #11559

Merged
merged 6 commits into from
Feb 10, 2020
Merged

Gamelift fleet tagging support #11559

merged 6 commits into from
Feb 10, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 11, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11384

Release note for CHANGELOG:

resource_aws_gamelift_fleet: add support for `tags` argument

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGameliftFleet_'
--- PASS: TestAccAWSGameliftFleet_basic (1764.12s)
--- PASS: TestAccAWSGameliftFleet_allFields (1641.65s)
--- PASS: TestAccAWSGameliftFleet_tags (1691.93s)
--- PASS: TestAccAWSGameliftFleet_disappears (1478.92s)
...

@DrFaust92 DrFaust92 requested a review from a team January 11, 2020 09:52
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/gamelift Issues and PRs that pertain to the gamelift service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jan 11, 2020
@DrFaust92 DrFaust92 changed the title [WIP]Gamelift fleet tagging support Gamelift fleet tagging support Jan 11, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 13, 2020
@bflad bflad added this to the v2.46.0 milestone Jan 17, 2020
@DrFaust92
Copy link
Collaborator Author

DrFaust92 commented Jan 17, 2020 •
edited
Loading

rebased and refactored

$ make testacc TESTARGS='-run=TestAccAWSGameliftFleet_'
--- PASS: TestAccAWSGameliftFleet_basic (1585.44s)
--- PASS: TestAccAWSGameliftFleet_allFields (1657.18s)
--- PASS: TestAccAWSGameliftFleet_basic (1585.44s)
--- PASS: TestAccAWSGameliftFleet_disappears (2678.51s)
...

@bflad bflad removed this from the v2.46.0 milestone Jan 23, 2020
@DrFaust92
add tagging support for gamefleet fleet
1e1d02c 
refactor tests
@DrFaust92
add docs
aefd73b
@DrFaust92
remove validation
fd56aad 
refactor tests
@DrFaust92
fix build name
e078649 
add disappearing test case
fix tagging test
@DrFaust92
skip tagging when deleting
c30e136 
wait more to finish disappearing test
@DrFaust92
rebase + refactor
709c6ea
bflad
bflad approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSGameliftFleet_disappears (1472.06s)
--- PASS: TestAccAWSGameliftFleet_basic (1527.98s)
--- PASS: TestAccAWSGameliftFleet_allFields (1572.85s)
--- PASS: TestAccAWSGameliftFleet_tags (1582.50s)

@bflad bflad added this to the v2.49.0 milestone Feb 10, 2020
@bflad bflad merged commit c24dbc4 into hashicorp:master Feb 10, 2020
bflad added a commit that referenced this pull request Feb 10, 2020
@bflad
Update CHANGELOG for #11559
ae462b1
@ghost
Copy link

ghost commented Feb 14, 2020

This has been released in version 2.49.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the game-fleet-tags branch March 15, 2020 07:49
@ghost
Copy link

ghost commented Mar 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/gamelift Issues and PRs that pertain to the gamelift service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.49.0
Development

Successfully merging this pull request may close these issues.

Amazon GameLift resource tagging
2 participants
@DrFaust92 @bflad