-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rd/launch_template - add partition_number
attribute + validations
#11655
Conversation
host_resource_group_arn
and partition_number
attributeshost_resource_group_arn
and partition_number
attributes
e5a9c89
to
41e3f66
Compare
host_resource_group_arn
and partition_number
attributeshost_resource_group_arn
and partition_number
attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, @DrFaust92. Can you add some testing for the new fields, please?
…source and data source add plan time validation to volume_type use arn test
41e3f66
to
c90e948
Compare
@gdavison , adding some tests for the partition number argument. i'll take a look at resource groups as well, may be more tricky |
`spot_instance_type`, `ipv6_addresses`, `private_ip_address`, `ipv4_addresses` add test for partition number
host_resource_group_arn
and partition_number
attributespartition_number
attribute
partition_number
attributepartition_number
attribute + validations
@gdavison dropped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
--- PASS: TestAccAWSLaunchTemplate_disappears (12.45s)
--- PASS: TestAccAWSLaunchTemplate_basic (12.88s)
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (14.32s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (15.21s)
--- PASS: TestAccAWSLaunchTemplate_data (16.08s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (16.76s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (17.16s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (17.28s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (17.69s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (17.73s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (18.52s)
--- PASS: TestAccAWSLaunchTemplate_tags (23.22s)
--- PASS: TestAccAWSLaunchTemplate_description (24.97s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (24.99s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (13.99s)
--- PASS: TestAccAWSLaunchTemplate_metadataOptions (12.99s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (16.44s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (16.43s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (24.58s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (19.92s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (27.36s)
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceAddresses (27.84s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (45.10s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (45.58s)
--- PASS: TestAccAWSLaunchTemplate_placement_partitionNum (28.76s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (49.69s)
--- PASS: TestAccAWSLaunchTemplate_hibernation (26.35s)
--- PASS: TestAccAWSLaunchTemplate_update (50.94s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (51.73s)
--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (35.52s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (56.41s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (48.02s)
This has been released in version 2.61.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
This change will give a default value of 0 to partition_number, causing cluster mode K8S ASG scaling up failure. |
Hi this MR will break other module like terraform-aws-eks which do not explicitly handle "partition_number". The "partition_number" will become "0" and create following error. |
We also make use of modules that don't handle Pinning the version for the provider fixes this: provider "aws" {
version = "<= 2.60.0"
region = "us-east-1
} |
This seems like a regression. |
I suspect this fix brought another issue: BTW: in our account we don't have any placement group. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Release note for CHANGELOG:
Output from acceptance testing: