Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_ecs_cluster: Delay check of ECS Cluster status during creation for ECS eventual consistency #11701

Merged
merged 1 commit into from
Feb 3, 2020
Merged

resource/aws_ecs_cluster: Delay check of ECS Cluster status during creation for ECS eventual consistency #11701

merged 1 commit into from
Feb 3, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 22, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

* resource/aws_ecs_cluster: Delay check of ECS Cluster status during creation for ECS eventual consistency

Previously in the acceptance testing (inconsistently):

--- FAIL: TestAccAWSAppautoScalingTarget_basic (5.62s)
    testing.go:640: Step 0 error: errors during apply:
        Error: ECS cluster "cluster-0bzcoev18m" missing

--- FAIL: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (4.36s)
    testing.go:640: Step 0 error: errors during apply:

        Error: ECS cluster "tf-acc-cluster-svc-w-ups-ijnv7v74" missing

We also add error message context when returning this error to help operators and code maintainers.

Output from acceptance testing:

--- PASS: TestAccAWSEcsCluster_disappears (22.99s)
--- PASS: TestAccAWSEcsCluster_basic (27.66s)
--- PASS: TestAccAWSEcsCluster_Tags (46.07s)
--- PASS: TestAccAWSEcsCluster_CapacityProviders (49.88s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersNoStrategy (52.59s)
--- PASS: TestAccAWSEcsCluster_containerInsights (66.84s)
--- PASS: TestAccAWSEcsCluster_SingleCapacityProvider (73.76s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (83.17s)

--- PASS: TestAccAWSAppautoScalingTarget_basic (54.12s)

--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (77.88s)

@bflad
resource/aws_ecs_cluster: Delay check of ECS Cluster status during cr…
5873425 
…eation for ECS eventual consistency

Previously in the acceptance testing (inconsistently):

```
--- FAIL: TestAccAWSAppautoScalingTarget_basic (5.62s)
    testing.go:640: Step 0 error: errors during apply:
        Error: ECS cluster "cluster-0bzcoev18m" missing

--- FAIL: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (4.36s)
    testing.go:640: Step 0 error: errors during apply:

        Error: ECS cluster "tf-acc-cluster-svc-w-ups-ijnv7v74" missing
```

We also add error message context when returning this error to help operators and code maintainers.

Output from acceptance testing:

```
--- PASS: TestAccAWSEcsCluster_disappears (22.99s)
--- PASS: TestAccAWSEcsCluster_basic (27.66s)
--- PASS: TestAccAWSEcsCluster_Tags (46.07s)
--- PASS: TestAccAWSEcsCluster_CapacityProviders (49.88s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersNoStrategy (52.59s)
--- PASS: TestAccAWSEcsCluster_containerInsights (66.84s)
--- PASS: TestAccAWSEcsCluster_SingleCapacityProvider (73.76s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (83.17s)

--- PASS: TestAccAWSAppautoScalingTarget_basic (54.12s)

--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (77.88s)
```
@bflad bflad added the bug Addresses a defect in current functionality. label Jan 22, 2020
@bflad bflad requested a review from a team January 22, 2020 02:07
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ecs Issues and PRs that pertain to the ecs service. labels Jan 22, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Jan 22, 2020
gdavison
gdavison approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSEcsCluster_disappears (17.70s)
--- PASS: TestAccAWSEcsCluster_basic (18.46s)
--- PASS: TestAccAWSEcsCluster_Tags (30.34s)
--- PASS: TestAccAWSEcsCluster_CapacityProviders (36.68s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersNoStrategy (47.31s)
--- PASS: TestAccAWSEcsCluster_containerInsights (49.14s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (62.77s)
--- PASS: TestAccAWSEcsCluster_SingleCapacityProvider (73.56s)

@bflad bflad added this to the v2.48.0 milestone Feb 3, 2020
@bflad bflad merged commit a3a4f0c into master Feb 3, 2020
@bflad bflad deleted the b-aws_ecs_cluster-waitForEcsClusterActive-Delay branch February 3, 2020 20:24
bflad added a commit that referenced this pull request Feb 3, 2020
@bflad
Update CHANGELOG for #11701
e2e4ce3
@ghost
Copy link

ghost commented Feb 7, 2020

This has been released in version 2.48.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.48.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bflad @gdavison