resource/aws_cloudformation_stack_set: Wait for update operation completion and report any errors

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

* resource/aws_cloudformation_stack_set: Wait for update operation completion (default timeout of 30 minutes) and report any errors

Previously in the acceptance testing:

--- FAIL: TestAccAWSCloudFormationStackSet_Parameters (35.78s)
    testing.go:640: Step 4 error: errors during apply:

        Error: error updating CloudFormation Stack Set (tf-acc-test-5503547290025742409): OperationInProgressException: Another Operation on StackSet arn:aws:cloudformation:us-west-2:*******:stackset/tf-acc-test-5503547290025742409:55908c5e-ea0e-482f-b21c-2c1fb21fb1ac is in progress
        	status code: 409, request id: c123a6e4-3577-4c85-8964-a898d81c597d

          on /opt/teamcity-agent/temp/buildTmp/tf-test708526898/main.tf line 7:
          (source code not available)

    testing.go:701: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

        Error: errors during apply: error deleting CloudFormation Stack Set (tf-acc-test-5503547290025742409): OperationInProgressException: Operation terraform-20200122114208738100000003 on StackSet arn:aws:cloudformation:us-west-2:*******:stackset/tf-acc-test-5503547290025742409:55908c5e-ea0e-482f-b21c-2c1fb21fb1ac is in progress
        	status code: 409, request id: b8059f09-effd-494a-8f43-17a6cac30d81

There are no StackSetOperation associated with CreateStackSet or DeleteStackSet.

Output from acceptance testing:

--- PASS: TestAccAWSCloudFormationStackSet_Description (38.41s)
--- PASS: TestAccAWSCloudFormationStackSet_disappears (41.35s)
--- PASS: TestAccAWSCloudFormationStackSet_ExecutionRoleName (57.63s)
--- PASS: TestAccAWSCloudFormationStackSet_Name (61.53s)
--- PASS: TestAccAWSCloudFormationStackSet_basic (72.71s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateUrl (73.85s)
--- PASS: TestAccAWSCloudFormationStackSet_AdministrationRoleArn (78.93s)
--- PASS: TestAccAWSCloudFormationStackSet_Parameters (104.93s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateBody (108.84s)
--- PASS: TestAccAWSCloudFormationStackSet_Tags (134.72s)

[gdavison]

There are intermittent errors in TeamCity:

Error: error waiting for CloudFormation Stack Set Instance (tf-acc-test-3697492415319361987,*******,us-west-2) creation: Operation (terraform-20200130031205795500000004) Results:
        Account (*******) Region (us-west-2) Status (FAILED) Status Reason: Account ******* should have 'tf-acc-test-3697492415319361987-Execution' role with trust relationship to Role 'tf-acc-test-3697492415319361987-Administration'.

[bflad]

@gdavison failures with the aws_cloudformation_stack_set_instance resource are unrelated to the changes/fixes here.

[gdavison]

LGTM 🚀

[ghost]

This has been released in version 2.48.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!