resource/aws_appautoscaling_target: Prevent state removal at creation #11819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References * hashicorp#11811 The AWS application-autoscaling service has eventual consistency considerations. The `aws_appautoscaling_target` resource immediately tries to read a scaling target after creation. If the target is not found, the application-autoscaling service returns a 200 OK with an empty list of scaling targets. Since no scaling target is present, the `aws_appautoscaling_target` resource removes the created resource from state, leading to a "produced an unexpected new value for was present, but now absent" error. With the changes in this commit, the empty list of scaling targets in the response for the newly created resource will result in a NotFoundError being returned and a retry of the read request. A subsequent retry should hopefully be successful, leading to the state being preserved. Output from acceptance testing: ``` > make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppautoScalingTarget_' ... --- PASS: TestAccAWSAppautoScalingTarget_multipleTargets (30.77s) --- PASS: TestAccAWSAppautoScalingTarget_optionalRoleArn (32.50s) --- PASS: TestAccAWSAppautoScalingTarget_spotFleetRequest (77.50s) --- PASS: TestAccAWSAppautoScalingTarget_basic (107.66s) --- PASS: TestAccAWSAppautoScalingTarget_emrCluster (783.20s) ```
ghost
added
size/XS
bflad
added
bug
bflad
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
Nice investigative work and implementation, @camlow325 🚀
Output from acceptance testing:
--- PASS: TestAccAWSAppautoScalingTarget_optionalRoleArn (15.68s)
--- PASS: TestAccAWSAppautoScalingTarget_multipleTargets (16.71s)
--- PASS: TestAccAWSAppautoScalingTarget_spotFleetRequest (59.88s)
--- PASS: TestAccAWSAppautoScalingTarget_basic (71.08s)
--- PASS: TestAccAWSAppautoScalingTarget_emrCluster (838.51s)
bflad
added a commit
that referenced
this pull request
Jan 31, 2020
|
This has been released in version 2.48.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #11811
Release note for CHANGELOG:
The AWS application-autoscaling service has eventual consistency considerations. The
aws_appautoscaling_targetresource immediately tries to read a scaling target after creation. If the target is not found, the application-autoscaling service returns a 200 OK with an empty list of scaling targets. Since no scaling target is present, theaws_appautoscaling_targetresource removes the created resource from state, leading to a "produced an unexpected new value for was present,but now absent" error.
With the changes in this commit, the empty list of scaling targets in the response for the newly created resource will result in a NotFoundError being returned and a retry of the read request. A subsequent retry should hopefully be successful, leading to the state being preserved.
Output from acceptance testing: