Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS AppSync integration with AWS X-Ray #11972

Merged
merged 3 commits into from
Mar 9, 2020

Conversation

nerixim
Copy link

@nerixim nerixim commented Feb 9, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11969

Release note for CHANGELOG:

resource/aws_appsync_graphql_api: Add `xray_enabled` argument

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppsyncGraphqlApi_XrayEnabled'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppsyncGraphqlApi_XrayEnabled -timeout 120m
=== RUN   TestAccAWSAppsyncGraphqlApi_XrayEnabled
=== PAUSE TestAccAWSAppsyncGraphqlApi_XrayEnabled
=== CONT  TestAccAWSAppsyncGraphqlApi_XrayEnabled
--- PASS: TestAccAWSAppsyncGraphqlApi_XrayEnabled (64.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	64.686s

@nerixim nerixim requested a review from a team February 9, 2020 12:53
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. service/appsync Issues and PRs that pertain to the appsync service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 9, 2020
@ghost ghost added size/S Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Feb 22, 2020
@nerixim nerixim changed the title [WIP] AWS AppSync integration with AWS X-Ray AWS AppSync integration with AWS X-Ray Feb 22, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed dependencies Used to indicate dependency changes. needs-triage Waiting for first response or review from a maintainer. labels Mar 6, 2020
@bflad bflad self-assigned this Mar 6, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @nerixim 🚀

Output from acceptance testing:

--- PASS: TestAccAWSAppsyncGraphqlApi_disappears (9.89s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction (25.14s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_AWSIAM (25.36s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM (27.15s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID (28.02s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType (29.94s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey (30.76s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_CognitoUserPools (23.31s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL (33.47s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect (34.84s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion (36.00s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Tags (36.15s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Schema (37.16s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer (37.91s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools (38.81s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_Multiple (14.27s)
--- PASS: TestAccAWSAppsyncGraphqlApi_basic (40.56s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_OpenIDConnect (18.61s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_APIKey (57.65s)
--- PASS: TestAccAWSAppsyncGraphqlApi_XrayEnabled (33.82s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig (62.58s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL (70.54s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Name (71.59s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel (77.19s)

@bflad bflad added this to the v2.53.0 milestone Mar 9, 2020
@bflad bflad merged commit 91676fb into hashicorp:master Mar 9, 2020
bflad added a commit that referenced this pull request Mar 9, 2020
bflad added a commit that referenced this pull request Mar 9, 2020
@ghost
Copy link

ghost commented Mar 12, 2020

This has been released in version 2.53.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/appsync Issues and PRs that pertain to the appsync service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS AppSync integration with AWS X-Ray
2 participants