add tagging support to ec2 traffic mirror target

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688

Release note for CHANGELOG:

resource_aws_ec2_traffic_mirror_target: add tagging support
resource_aws_ec2_traffic_mirror_target: add plan time validation to `network_load_balancer_arn`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEc2TrafficMirrorTarget_'
--- PASS: TestAccAWSEc2TrafficMirrorTarget_nlb (304.92s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_eni (372.81s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_tags (422.67s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_disappears (317.51s)

[ewbankkit]

Verified acceptance tests:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSEc2TrafficMirrorTarget_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 1 -run=TestAccAWSEc2TrafficMirrorTarget_ -timeout 120m
=== RUN   TestAccAWSEc2TrafficMirrorTarget_nlb
=== PAUSE TestAccAWSEc2TrafficMirrorTarget_nlb
=== RUN   TestAccAWSEc2TrafficMirrorTarget_eni
=== PAUSE TestAccAWSEc2TrafficMirrorTarget_eni
=== RUN   TestAccAWSEc2TrafficMirrorTarget_tags
=== PAUSE TestAccAWSEc2TrafficMirrorTarget_tags
=== RUN   TestAccAWSEc2TrafficMirrorTarget_disappears
=== PAUSE TestAccAWSEc2TrafficMirrorTarget_disappears
=== CONT  TestAccAWSEc2TrafficMirrorTarget_nlb
--- PASS: TestAccAWSEc2TrafficMirrorTarget_nlb (245.14s)
=== CONT  TestAccAWSEc2TrafficMirrorTarget_disappears
--- PASS: TestAccAWSEc2TrafficMirrorTarget_disappears (276.08s)
=== CONT  TestAccAWSEc2TrafficMirrorTarget_tags
--- PASS: TestAccAWSEc2TrafficMirrorTarget_tags (290.34s)
=== CONT  TestAccAWSEc2TrafficMirrorTarget_eni
--- PASS: TestAccAWSEc2TrafficMirrorTarget_eni (109.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	922.017s

[bflad]

Looks good, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEc2TrafficMirrorTarget_eni (74.21s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_tags (377.38s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_disappears (591.15s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_nlb (750.29s)

[ghost]

This has been released in version 2.53.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!