Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Sources: aws_ec2_instance_type_offering and aws_ec2_instance_type_offerings #12139

Merged
merged 2 commits into from
Mar 4, 2020
Merged

New Data Sources: aws_ec2_instance_type_offering and aws_ec2_instance_type_offerings #12139

merged 2 commits into from
Mar 4, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 23, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #10989

Release note for CHANGELOG:

* **New Data Source:** `aws_ec2_instance_type_offering`
* **New Data Source:** `aws_ec2_instance_type_offerings`

These new data source can be used to replace our "hardcoded" usw2-az4 Availability Zone ID blacklisting for certain EC2 Instance Types in the acceptance testing as well as allow operators to more conditionally select only available instance types in regions and availability zones.

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter (15.95s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType (17.38s)

--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_PreferredInstanceTypes (15.95s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_Filter (17.42s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_LocationType (19.22s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter (21.98s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType (23.84s)

--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_PreferredInstanceTypes (21.88s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_Filter (23.58s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_LocationType (25.70s)

@bflad
New Data Source: aws_ec2_instance_type_offerings
809a3de 
Reference: #10989

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter (15.95s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType (17.38s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter (21.98s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType (23.84s)
```
@bflad
New Data Source: aws_ec2_instance_type_offering
3bdf8e3 
Reference: #10989

Output from acceptance testing:

```
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_PreferredInstanceTypes (15.95s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_Filter (17.42s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_LocationType (19.22s)
```
@bflad bflad added new-data-source Introduces a new data source. service/ec2 Issues and PRs that pertain to the ec2 service. labels Feb 23, 2020
@bflad bflad requested a review from a team February 23, 2020 19:37
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Feb 23, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Feb 23, 2020
@bflad bflad mentioned this pull request Feb 23, 2020
Closed
gdavison
gdavison approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_PreferredInstanceTypes (8.75s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter (9.30s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType (9.44s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_Filter (9.80s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_LocationType (9.89s)

@bflad bflad added this to the v2.52.0 milestone Mar 4, 2020
@bflad bflad merged commit e9bfb75 into master Mar 4, 2020
@bflad bflad deleted the f-aws_ec2_instance_type_offerings branch March 4, 2020 02:28
bflad added a commit that referenced this pull request Mar 4, 2020
@bflad
Update CHANGELOG for #12139
fa8d7d0
@ghost
Copy link

ghost commented Mar 6, 2020

This has been released in version 2.52.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.52.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bflad @gdavison