Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_media_store_container: Prevent ValidationException on creation when no tags are configured #12170

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 26, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

* resource/aws_media_store_container: Prevent `ValidationException` error on creation when no tags are configured

Previously from the acceptance testing (started February 18, 2020):

--- FAIL: TestAccAWSMediaStoreContainer_basic (2.83s)
    testing.go:654: Step 0 error: errors during apply:

        Error: ValidationException: 1 validation error detected: Value '[]' at 'tags' failed to satisfy constraint: Member must have length greater than or equal to 1

Output from acceptance testing:

--- PASS: TestAccAWSMediaStoreContainer_tags (127.62s)
--- PASS: TestAccAWSMediaStoreContainer_basic (141.24s)

…eation when no tags are configured

Previously from the acceptance testing (started Feburary 18, 2020):

```
--- FAIL: TestAccAWSMediaStoreContainer_basic (2.83s)
    testing.go:654: Step 0 error: errors during apply:

        Error: ValidationException: 1 validation error detected: Value '[]' at 'tags' failed to satisfy constraint: Member must have length greater than or equal to 1
```

Output from acceptance testing:

```
--- PASS: TestAccAWSMediaStoreContainer_tags (127.62s)
--- PASS: TestAccAWSMediaStoreContainer_basic (141.24s)
```
@bflad bflad added the bug Addresses a defect in current functionality. label Feb 26, 2020
@bflad bflad requested a review from a team February 26, 2020 01:40
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/mediastore Issues and PRs that pertain to the mediastore service. labels Feb 26, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Feb 26, 2020
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSMediaStoreContainer_basic (93.93s)
--- PASS: TestAccAWSMediaStoreContainer_tags (103.13s)

@bflad bflad added this to the v2.52.0 milestone Mar 4, 2020
@bflad bflad merged commit 5954746 into master Mar 4, 2020
@bflad bflad deleted the b-aws_media_store_container-tags branch March 4, 2020 02:35
bflad added a commit that referenced this pull request Mar 4, 2020
@ghost
Copy link

ghost commented Mar 6, 2020

This has been released in version 2.52.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/mediastore Issues and PRs that pertain to the mediastore service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants