resource/aws_lambda_function_event_invoke_config: Retry on additional IAM eventual consistency error with SNS Topic destinations

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

* resource/aws_lambda_function_event_invoke_config: Retry on additional IAM eventual consistency error with SNS Topic destinations

Previous output from acceptance testing (starting January 8, 2020):

--- FAIL: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnFailure_Destination (39.34s)
    testing.go:654: Step 2 error: errors during apply:

        Error: error putting Lambda Function Event Invoke Config (tf-acc-test-2587868650326248481): InvalidParameterValueException: The function's execution role does not have permissions to call Publish on arn:aws:sns:us-west-2:*******:tf-acc-test-2587868650326248481

--- FAIL: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnSuccess_Destination (38.93s)
    testing.go:654: Step 2 error: errors during apply:

        Error: error putting Lambda Function Event Invoke Config (tf-acc-test-3054348441165405395): InvalidParameterValueException: The function's execution role does not have permissions to call Publish on arn:aws:sns:us-west-2:*******:tf-acc-test-3054348441165405395

Output from acceptance testing:

--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_Latest (61.87s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionVersion (90.83s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunction (93.91s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunctionEventInvokeConfig (94.80s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_FunctionName_Arn (99.33s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Swap (101.83s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumEventAgeInSeconds (104.62s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_AliasName (106.73s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnFailure_Destination (107.43s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_basic (110.48s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumRetryAttempts (145.50s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Remove (146.86s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnSuccess_Destination (151.83s)

[gdavison]

The contents of resourceAwsLambdaFunctionEventInvokeConfigCreate() and resourceAwsLambdaFunctionEventInvokeConfigUpdate() are mostly identical. Would it make sense to factor out the common parts?

[gdavison]

LGTM, other than the refactoring question 🚀

--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunction (27.97s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumEventAgeInSeconds (37.98s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunctionEventInvokeConfig (38.52s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionVersion (38.66s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_AliasName (39.38s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_basic (39.52s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_Latest (40.14s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_FunctionName_Arn (40.09s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnFailure_Destination (44.12s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Swap (48.07s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Remove (48.36s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumRetryAttempts (54.52s)
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnSuccess_Destination (63.43s)

[bflad]

The contents of resourceAwsLambdaFunctionEventInvokeConfigCreate() and resourceAwsLambdaFunctionEventInvokeConfigUpdate() are mostly identical. Would it make sense to factor out the common parts?

Since Create and Update usually tend to differ on resources (e.g. different API call, SDK input types, ForceNew), we've historically preferred being verbose with no indirection for each resource function as the consistent implementation across all of them, but there are probably resources like this one with very similar shared logic. As long as the proposed logic does not introduce Go interfaces or complicated d.IsNewResource() logic, there probably is not too much reason to sway either which way other than making sure if there is a new standard it is documented/consistent itself so we don't recreate the XKCD. 😄

[ghost]

This has been released in version 2.52.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!