Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_eks_cluster: Add encryption_config configuration block #12280

Merged
merged 2 commits into from
Mar 6, 2020
Merged

resource/aws_eks_cluster: Add encryption_config configuration block #12280

merged 2 commits into from
Mar 6, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 5, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

* resource/aws_eks_cluster: Add `encryption_config` configuration block

Output from acceptance testing:

--- PASS: TestAccAWSEksCluster_VpcConfig_SecurityGroupIds (1190.44s)
--- PASS: TestAccAWSEksCluster_basic (1199.87s)
--- PASS: TestAccAWSEksCluster_EncryptionConfig (1283.39s)
--- PASS: TestAccAWSEksCluster_Tags (1317.91s)
--- PASS: TestAccAWSEksCluster_Logging (1328.91s)
--- PASS: TestAccAWSEksCluster_VpcConfig_PublicAccessCidrs (1530.21s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPublicAccess (1932.53s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPrivateAccess (2388.84s)
--- PASS: TestAccAWSEksCluster_Version (2559.12s)

@bflad
resource/aws_eks_cluster: Add encryption_config configuration block
3c97689 
Output from acceptance testing:

```
--- PASS: TestAccAWSEksCluster_VpcConfig_SecurityGroupIds (1190.44s)
--- PASS: TestAccAWSEksCluster_basic (1199.87s)
--- PASS: TestAccAWSEksCluster_EncryptionConfig (1283.39s)
--- PASS: TestAccAWSEksCluster_Tags (1317.91s)
--- PASS: TestAccAWSEksCluster_Logging (1328.91s)
--- PASS: TestAccAWSEksCluster_VpcConfig_PublicAccessCidrs (1530.21s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPublicAccess (1932.53s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPrivateAccess (2388.84s)
--- PASS: TestAccAWSEksCluster_Version (2559.12s)
```
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 5, 2020
@bflad bflad requested a review from a team March 5, 2020 22:25
@ghost ghost added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Mar 5, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Mar 5, 2020
gdavison
gdavison approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than the linting errors 🚀

--- PASS: TestAccAWSEksCluster_basic (1171.70s)
--- PASS: TestAccAWSEksCluster_Tags (1230.56s)
--- PASS: TestAccAWSEksCluster_Logging (1235.75s)
--- PASS: TestAccAWSEksCluster_EncryptionConfig (1280.24s)
--- PASS: TestAccAWSEksCluster_VpcConfig_SecurityGroupIds (1281.59s)
--- PASS: TestAccAWSEksCluster_VpcConfig_PublicAccessCidrs (1346.46s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPublicAccess (2093.13s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPrivateAccess (2293.72s)
--- PASS: TestAccAWSEksCluster_Version (2542.85s)

@bflad
resource/aws_eks_cluster: Remove extraneous nil checks
c88b1db 
Previously:

```
aws/resource_aws_eks_cluster.go:476:5: S1009: should omit nil check; len() for nil slices is defined as zero (gosimple)
	if tfList == nil || len(tfList) == 0 {
	   ^
aws/resource_aws_eks_cluster.go:617:5: S1009: should omit nil check; len() for nil slices is defined as zero (gosimple)
	if apiObjects == nil || len(apiObjects) == 0 {
	   ^
```
@bflad bflad added this to the v2.52.0 milestone Mar 6, 2020
@bflad
Copy link
Contributor Author

bflad commented Mar 6, 2020

Trivial gosimple fix passes CI, merging!

@bflad bflad merged commit 9ec9d56 into master Mar 6, 2020
@bflad bflad deleted the f-aws_eks_cluster-encryption_config branch March 6, 2020 14:36
bflad added a commit that referenced this pull request Mar 6, 2020
@bflad
Update CHANGELOG for #12280
e993cdc
This was referenced Mar 6, 2020
Closed
Closed
@ghost
Copy link

ghost commented Mar 6, 2020

This has been released in version 2.52.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.52.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bflad @gdavison