Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling for alternative errors #12283

Merged
merged 2 commits into from
Mar 12, 2020
Merged

Fix error handling for alternative errors #12283

merged 2 commits into from
Mar 12, 2020

Conversation

eldondev
Copy link
Contributor

@eldondev eldondev commented Mar 6, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Improve EBS Snapshot copy error handling

@eldondev
Push errors not handled here to the caller
50ebc94 
This component previously could cause terraform to panic in the case
that an unexpected error was encountered when attempting to find a
particular snapshot.
@eldondev eldondev requested a review from a team March 6, 2020 06:12
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. labels Mar 6, 2020
bflad
bflad suggested changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, thanks for submitting this, @eldondev 👍 Minor update and this should be good to go.

aws/resource_aws_ebs_snapshot_copy.go Outdated Show resolved Hide resolved
@bflad bflad added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 6, 2020
@eldondev @bflad
Wrap with more descriptive error message
edbc454 
Co-Authored-By: Brian Flad <bflad417@gmail.com>
@bflad bflad self-assigned this Mar 9, 2020
@bflad bflad self-requested a review March 9, 2020 16:20
@bflad bflad modified the milestones: v2.53.0, v2.54.0 Mar 9, 2020
bflad
bflad approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for fixing this, @eldondev 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEbsSnapshotCopy_tags (61.37s)
--- PASS: TestAccAWSEbsSnapshotCopy_basic (66.61s)
--- PASS: TestAccAWSEbsSnapshotCopy_withKms (69.05s)
--- PASS: TestAccAWSEbsSnapshotCopy_withRegions (74.66s)
--- PASS: TestAccAWSEbsSnapshotCopy_disappears (81.63s)
--- PASS: TestAccAWSEbsSnapshotCopy_withDescription (81.96s)

@bflad bflad merged commit cce8f23 into hashicorp:master Mar 12, 2020
bflad added a commit that referenced this pull request Mar 12, 2020
@bflad
Update CHANGELOG for #12283
eeca72c
@ghost
Copy link

ghost commented Mar 19, 2020

This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.54.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eldondev @bflad