-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_vpc_endpoint_service - tag on create + read after create #12290
r/aws_vpc_endpoint_service - tag on create + read after create #12290
Conversation
read after create plan time validation for nlb arns
Verified acceptance tests: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpointService_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSVpcEndpointService_ -timeout 120m
=== RUN TestAccAWSVpcEndpointService_basic
=== PAUSE TestAccAWSVpcEndpointService_basic
=== RUN TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags
=== PAUSE TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags
=== RUN TestAccAWSVpcEndpointService_removed
=== PAUSE TestAccAWSVpcEndpointService_removed
=== CONT TestAccAWSVpcEndpointService_basic
=== CONT TestAccAWSVpcEndpointService_removed
=== CONT TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags
--- PASS: TestAccAWSVpcEndpointService_removed (267.59s)
--- PASS: TestAccAWSVpcEndpointService_basic (268.96s)
--- PASS: TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags (294.26s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 294.291s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @DrFaust92 🚀
Output from acceptance testing:
--- PASS: TestAccAWSVpcEndpointService_basic (219.96s)
--- PASS: TestAccAWSVpcEndpointServiceAllowedPrincipal_basic (230.25s)
--- PASS: TestAccAWSVpcEndpointService_removed (230.69s)
--- PASS: TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags (237.43s)
This has been released in version 2.53.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Release note for CHANGELOG:
Output from acceptance testing: