r/aws_route53_health_check - suppress diff when expanded ipv6 address is the same

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11069

Release note for CHANGELOG:

resource_aws_route53_health_check: do not recreate health check when using compressed ipv6 address.
resource_aws_route53_health_check: add plan time validation to `insufficient_data_health_status`.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSRoute53HealthCheck_'
--- PASS: TestAccAWSRoute53HealthCheck_basic (72.75s)
--- PASS: TestAccAWSRoute53HealthCheck_IpConfig (43.30s)
--- PASS: TestAccAWSRoute53HealthCheck_Ipv6Config (44.32s)
--- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (54.50s)
--- PASS: TestAccAWSRoute53HealthCheck_withSNI (103.25s)
--- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (50.15s)
--- PASS: TestAccAWSRoute53HealthCheck_withHealthCheckRegions (42.71s)
--- PASS: TestAccAWSRoute53HealthCheck_withSearchString (72.53s)
--- PASS: TestAccAWSRoute53HealthCheck_tags (101.66s)
--- PASS: TestAccAWSRoute53HealthCheck_disappears (35.03s)

[ewbankkit]

Verified acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSRoute53HealthCheck_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53HealthCheck_ -timeout 120m
=== RUN   TestAccAWSRoute53HealthCheck_basic
=== PAUSE TestAccAWSRoute53HealthCheck_basic
=== RUN   TestAccAWSRoute53HealthCheck_tags
=== PAUSE TestAccAWSRoute53HealthCheck_tags
=== RUN   TestAccAWSRoute53HealthCheck_withSearchString
=== PAUSE TestAccAWSRoute53HealthCheck_withSearchString
=== RUN   TestAccAWSRoute53HealthCheck_withChildHealthChecks
=== PAUSE TestAccAWSRoute53HealthCheck_withChildHealthChecks
=== RUN   TestAccAWSRoute53HealthCheck_withHealthCheckRegions
=== PAUSE TestAccAWSRoute53HealthCheck_withHealthCheckRegions
=== RUN   TestAccAWSRoute53HealthCheck_IpConfig
=== PAUSE TestAccAWSRoute53HealthCheck_IpConfig
=== RUN   TestAccAWSRoute53HealthCheck_Ipv6Config
=== PAUSE TestAccAWSRoute53HealthCheck_Ipv6Config
=== RUN   TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck
=== PAUSE TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck
=== RUN   TestAccAWSRoute53HealthCheck_withSNI
=== PAUSE TestAccAWSRoute53HealthCheck_withSNI
=== RUN   TestAccAWSRoute53HealthCheck_disappears
=== PAUSE TestAccAWSRoute53HealthCheck_disappears
=== CONT  TestAccAWSRoute53HealthCheck_basic
=== CONT  TestAccAWSRoute53HealthCheck_Ipv6Config
=== CONT  TestAccAWSRoute53HealthCheck_disappears
=== CONT  TestAccAWSRoute53HealthCheck_IpConfig
=== CONT  TestAccAWSRoute53HealthCheck_withHealthCheckRegions
=== CONT  TestAccAWSRoute53HealthCheck_withChildHealthChecks
=== CONT  TestAccAWSRoute53HealthCheck_withSearchString
=== CONT  TestAccAWSRoute53HealthCheck_tags
=== CONT  TestAccAWSRoute53HealthCheck_withSNI
=== CONT  TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck
--- PASS: TestAccAWSRoute53HealthCheck_disappears (17.66s)
--- PASS: TestAccAWSRoute53HealthCheck_withHealthCheckRegions (22.79s)
--- PASS: TestAccAWSRoute53HealthCheck_IpConfig (23.30s)
--- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (23.91s)
--- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (28.14s)
--- PASS: TestAccAWSRoute53HealthCheck_Ipv6Config (36.35s)
--- PASS: TestAccAWSRoute53HealthCheck_basic (36.36s)
--- PASS: TestAccAWSRoute53HealthCheck_withSearchString (37.08s)
--- PASS: TestAccAWSRoute53HealthCheck_withSNI (53.14s)
--- PASS: TestAccAWSRoute53HealthCheck_tags (53.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	53.292s

[gdavison]

One suggestion about the tests, but otherwise LGTM 🚀

--- PASS: TestAccAWSRoute53HealthCheck_disappears (9.15s)
--- PASS: TestAccAWSRoute53HealthCheck_IpConfig (18.18s)
--- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (18.94s)
--- PASS: TestAccAWSRoute53HealthCheck_basic (22.69s)
--- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (27.64s)
--- PASS: TestAccAWSRoute53HealthCheck_withSearchString (27.71s)
--- PASS: TestAccAWSRoute53HealthCheck_Ipv6Config (29.90s)
--- PASS: TestAccAWSRoute53HealthCheck_withSNI (31.01s)
--- PASS: TestAccAWSRoute53HealthCheck_withHealthCheckRegions (35.22s)
--- PASS: TestAccAWSRoute53HealthCheck_tags (35.68s)

[gdavison]

There's a test failure in TestAccAWSRoute53HealthCheck_basic now.

[gdavison]

This test changes values, so leaving it as a Check would be good.

[DrFaust92]

oops, didnt mean to change that.

[gdavison]

LGTM 🚀

--- PASS: TestAccAWSRoute53HealthCheck_disappears (8.41s)
--- PASS: TestAccAWSRoute53HealthCheck_IpConfig (13.69s)
--- PASS: TestAccAWSRoute53HealthCheck_withHealthCheckRegions (14.79s)
--- PASS: TestAccAWSRoute53HealthCheck_Ipv6Config (19.80s)
--- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (22.49s)
--- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (23.64s)
--- PASS: TestAccAWSRoute53HealthCheck_withSearchString (27.91s)
--- PASS: TestAccAWSRoute53HealthCheck_basic (32.58s)
--- PASS: TestAccAWSRoute53HealthCheck_tags (35.41s)
--- PASS: TestAccAWSRoute53HealthCheck_withSNI (37.42s)

[ghost]

This has been released in version 2.55.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!