Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support case insensitive usernames for Cognito user pools #12317

Merged

Conversation

garretruh
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12094

Release note for CHANGELOG:

resource/aws_cognito_user_pool: Add `username_configuration` configuration block and nested `case_sensitive` argument

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCognitoUserPool_withUsernameConfiguration'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCognitoUserPool_withUsernameConfiguration -timeout 120m
=== RUN   TestAccAWSCognitoUserPool_withUsernameConfiguration
=== PAUSE TestAccAWSCognitoUserPool_withUsernameConfiguration
=== CONT  TestAccAWSCognitoUserPool_withUsernameConfiguration
--- PASS: TestAccAWSCognitoUserPool_withUsernameConfiguration (48.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	48.837s

@garretruh garretruh requested a review from a team March 9, 2020 17:14
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/cognito tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 9, 2020
@garretruh garretruh force-pushed the feature/cognito-username-configuration branch from ebee9d9 to 6541d44 Compare March 10, 2020 14:19
@garretruh garretruh force-pushed the feature/cognito-username-configuration branch from 6541d44 to b26fa72 Compare March 13, 2020 13:54
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 17, 2020
@bflad bflad self-assigned this Mar 17, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks so much, @garretruh 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCognitoUserPool_basic (14.28s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfiguration (59.78s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationAndSoftwareTokenMfaConfiguration (53.46s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationToSoftwareTokenMfaConfiguration (45.32s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfiguration (32.68s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfigurationToSmsConfiguration (42.14s)
--- PASS: TestAccAWSCognitoUserPool_SmsAuthenticationMessage (24.09s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration (47.49s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_ExternalId (60.99s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_SnsCallerArn (52.91s)
--- PASS: TestAccAWSCognitoUserPool_SmsVerificationMessage (19.93s)
--- PASS: TestAccAWSCognitoUserPool_update (40.67s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration (31.63s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy (14.25s)
--- PASS: TestAccAWSCognitoUserPool_withAdvancedSecurityMode (27.60s)
--- PASS: TestAccAWSCognitoUserPool_withAliasAttributes (27.16s)
--- PASS: TestAccAWSCognitoUserPool_withDeviceConfiguration (21.90s)
--- PASS: TestAccAWSCognitoUserPool_withEmailVerificationMessage (20.98s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig (43.57s)
--- PASS: TestAccAWSCognitoUserPool_withPasswordPolicy (18.48s)
--- PASS: TestAccAWSCognitoUserPool_withSchemaAttributes (21.49s)
--- PASS: TestAccAWSCognitoUserPool_withTags (32.27s)
--- PASS: TestAccAWSCognitoUserPool_withUsernameConfiguration (18.98s)
--- PASS: TestAccAWSCognitoUserPool_withVerificationMessageTemplate (24.12s)

@bflad bflad added this to the v2.54.0 milestone Mar 17, 2020
@bflad bflad merged commit a2fc351 into hashicorp:master Mar 17, 2020
bflad added a commit that referenced this pull request Mar 17, 2020
@ghost
Copy link

ghost commented Mar 19, 2020

This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
@garretruh garretruh deleted the feature/cognito-username-configuration branch June 8, 2020 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cognito User Pool: Add support for case sensitivity flag
2 participants