Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1 hour backup interval for DLM #12327

Merged

Conversation

tomelliff
Copy link
Contributor

DLM now supports 1 hour intervals.

See https://aws.amazon.com/about-aws/whats-new/2020/03/amazon-data-lifecycle-manager-adds-support-for-1-hour-backup-interval/ for more information.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

`resource/aws_dlm_lifecycle_policy`: Add validation support for 1 hour schedules in `policy_details` `schedule` `create_rule` `interval` argument (support 1 hour intervals)

Output from acceptance testing:

I haven't ran the acceptance tests because it's just an extra value in a ValidateFunc.IntInSlice method.

@tomelliff tomelliff requested a review from a team March 10, 2020 12:18
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/dlm Issues and PRs that pertain to the dlm service. documentation Introduces or discusses updates to documentation. labels Mar 10, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 17, 2020
@bflad bflad added this to the v2.54.0 milestone Mar 17, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tomelliff 🚀

@bflad bflad merged commit e4e8287 into hashicorp:master Mar 17, 2020
bflad added a commit that referenced this pull request Mar 17, 2020
@ghost
Copy link

ghost commented Mar 19, 2020

This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@tomelliff tomelliff deleted the add-1-hour-backup-interval-for-dlm branch April 14, 2020 15:45
@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/dlm Issues and PRs that pertain to the dlm service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants