Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_iam_role Added Tags as an output. #12349

Merged
merged 2 commits into from
Mar 16, 2020
Merged

d/aws_iam_role Added Tags as an output. #12349

merged 2 commits into from
Mar 16, 2020

Conversation

robh007
Copy link
Contributor

@robh007 robh007 commented Mar 11, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

data/aws_iam_role Adds tags as an output to the resource.

Output from acceptance testing:

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDataSourceIAMRole'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSDataSourceIAMRole -timeout 120m
=== RUN   TestAccAWSDataSourceIAMRole_basic
=== PAUSE TestAccAWSDataSourceIAMRole_basic
=== RUN   TestAccAWSDataSourceIAMRole_tags
=== PAUSE TestAccAWSDataSourceIAMRole_tags
=== CONT  TestAccAWSDataSourceIAMRole_basic
=== CONT  TestAccAWSDataSourceIAMRole_tags
--- PASS: TestAccAWSDataSourceIAMRole_basic (31.14s)
--- PASS: TestAccAWSDataSourceIAMRole_tags (31.63s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       31.684s


...

@robh007 robh007 requested a review from a team March 11, 2020 11:31
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Mar 11, 2020
ewbankkit
ewbankkit reviewed Mar 12, 2020
View reviewed changes
aws/data_source_aws_iam_role.go Outdated
@@ -97,6 +99,10 @@ func dataSourceAwsIAMRoleRead(d *schema.ResourceData, meta interface{}) error {
}
d.Set("unique_id", output.Role.RoleId)

if len(output.Role.Tags) > 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robh007 Thanks for this.
if len(output.Role.Tags) > 0 shouldn't be necessary here as keyvaluetags.IamKeyValueTags can handle that case.

ewbankkit
ewbankkit reviewed Mar 12, 2020
View reviewed changes
aws/data_source_aws_iam_role_test.go
@@ -34,6 +34,35 @@ func TestAccAWSDataSourceIAMRole_basic(t *testing.T) {
})
}

func TestAccAWSDataSourceIAMRole_tags(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also test resource.TestCheckResourceAttr(dataSourceName, "tags.%", "0"), in the TestAccAWSDataSourceIAMRole_basic case?

@robh007
Copy link
Contributor Author

robh007 commented Mar 13, 2020

Updated as per comments from @ewbankkit. Test output below.

 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDataSourceIAMRole'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSDataSourceIAMRole -timeout 120m
=== RUN   TestAccAWSDataSourceIAMRole_basic
=== PAUSE TestAccAWSDataSourceIAMRole_basic
=== RUN   TestAccAWSDataSourceIAMRole_tags
=== PAUSE TestAccAWSDataSourceIAMRole_tags
=== CONT  TestAccAWSDataSourceIAMRole_basic
=== CONT  TestAccAWSDataSourceIAMRole_tags
--- PASS: TestAccAWSDataSourceIAMRole_basic (29.49s)
--- PASS: TestAccAWSDataSourceIAMRole_tags (29.64s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       29.704s

@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDataSourceIAMRole_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSDataSourceIAMRole_ -timeout 120m
=== RUN   TestAccAWSDataSourceIAMRole_basic
=== PAUSE TestAccAWSDataSourceIAMRole_basic
=== RUN   TestAccAWSDataSourceIAMRole_tags
=== PAUSE TestAccAWSDataSourceIAMRole_tags
=== CONT  TestAccAWSDataSourceIAMRole_basic
=== CONT  TestAccAWSDataSourceIAMRole_tags
--- PASS: TestAccAWSDataSourceIAMRole_tags (22.64s)
--- PASS: TestAccAWSDataSourceIAMRole_basic (23.57s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	23.613s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 16, 2020
@bflad bflad added this to the v2.54.0 milestone Mar 16, 2020
bflad
bflad approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @robh007 🚀

Output from acceptance testing:

--- PASS: TestAccAWSDataSourceIAMRole_basic (11.16s)
--- PASS: TestAccAWSDataSourceIAMRole_tags (11.53s)

@bflad bflad merged commit fe1c411 into hashicorp:master Mar 16, 2020
bflad added a commit that referenced this pull request Mar 16, 2020
@bflad
Update CHANGELOG for #12349
3d2c734
@ghost
Copy link

ghost commented Mar 19, 2020

This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit left review comments

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.54.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robh007 @ewbankkit @bflad