Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodePipeline cross-region action support #12549

Merged
merged 16 commits into from
Apr 2, 2020

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Mar 26, 2020

This PR picks up on the work done by @bashton-ajenkins in #7866 to add cross-region actions.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #7866
Closes #6871

Release note for CHANGELOG:

resource/aws_codepipeline: Adds cross-region action support

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodePipeline_'

--- PASS: TestAccAWSCodePipeline_emptyArtifacts (33.68s)
--- PASS: TestAccAWSCodePipeline_deployWithServiceRole (43.31s)
--- PASS: TestAccAWSCodePipeline_multiregion_basic (43.95s)
--- PASS: TestAccAWSCodePipeline_basic (57.33s)
--- PASS: TestAccAWSCodePipeline_multiregion_Update (66.48s)
--- PASS: TestAccAWSCodePipeline_tags (76.28s)
--- PASS: TestAccAWSCodePipeline_multiregion_ConvertSingleRegion (82.51s)

@ghost ghost added needs-triage Waiting for first response or review from a maintainer. service/codepipeline Issues and PRs that pertain to the codepipeline service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. size/XL Managed by automation to categorize the size of a PR. labels Mar 26, 2020
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Mar 26, 2020
@jrstarke
Copy link
Contributor

@gdavison is there any help you could use on this PR or any way that the community could help move this forward :)

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Mar 30, 2020
@gdavison gdavison marked this pull request as ready for review April 1, 2020 00:00
@gdavison gdavison requested a review from a team April 1, 2020 00:00
@bflad bflad self-assigned this Apr 1, 2020
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 1, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is looking pretty good, just requesting some changes for the testing. 👍

aws/resource_aws_codepipeline_test.go Show resolved Hide resolved
aws/resource_aws_codepipeline_test.go Outdated Show resolved Hide resolved
aws/resource_aws_codepipeline_test.go Outdated Show resolved Hide resolved
@bflad bflad assigned gdavison and unassigned bflad Apr 1, 2020
@gdavison gdavison added this to the v2.56.0 milestone Apr 1, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

Output from acceptance testing:

--- PASS: TestResourceAWSCodePipelineExpandArtifactStoresValidation (0.00s)
--- PASS: TestAccAWSCodePipelineWebhook_basic (24.22s)
--- PASS: TestAccAWSCodePipeline_basic (33.62s)
--- PASS: TestAccAWSCodePipelineWebhook_unauthenticated (34.61s)
--- PASS: TestAccAWSCodePipeline_deployWithServiceRole (36.14s)
--- PASS: TestAccAWSCodePipelineWebhook_ipAuth (37.23s)
--- PASS: TestAccAWSCodePipeline_emptyArtifacts (43.23s)
--- PASS: TestAccAWSCodePipeline_multiregion_basic (48.49s)
--- PASS: TestAccAWSCodePipeline_tags (54.44s)
--- PASS: TestAccAWSCodePipelineWebhook_UpdateAuthenticationConfiguration_SecretToken (59.03s)
--- PASS: TestAccAWSCodePipeline_multiregion_Update (66.93s)
--- PASS: TestAccAWSCodePipelineWebhook_tags (68.17s)
--- PASS: TestAccAWSCodePipeline_multiregion_ConvertSingleRegion (71.34s)

@ghost
Copy link

ghost commented Apr 3, 2020

This has been released in version 2.56.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@gdavison gdavison deleted the ajj/add-codepipeline-action-region-support branch April 18, 2020 00:17
@ghost
Copy link

ghost commented May 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/codepipeline Issues and PRs that pertain to the codepipeline service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
4 participants