Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: aws_efs_mount_target #1255

Merged
merged 1 commit into from Jul 28, 2017
Merged

New Data Source: aws_efs_mount_target #1255

merged 1 commit into from Jul 28, 2017

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jul 27, 2017

Fixes: #1207

% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsEfsMountTarget'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsEfsMountTarget -timeout 120m
=== RUN   TestAccDataSourceAwsEfsMountTargetByMountTargetId
--- PASS: TestAccDataSourceAwsEfsMountTargetByMountTargetId (253.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	253.094s

@stack72
New Data Source: aws_efs_mount_target
ac5d04a 
Fixes: hashicorp#1207

```
% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsEfsMountTarget'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsEfsMountTarget -timeout 120m
=== RUN   TestAccDataSourceAwsEfsMountTargetByMountTargetId
--- PASS: TestAccDataSourceAwsEfsMountTargetByMountTargetId (253.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	253.094s
```
@Ninir Ninir added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 28, 2017
@grubernaut grubernaut added the new-data-source Introduces a new data source. label Jul 28, 2017
grubernaut
grubernaut suggested changes Jul 28, 2017
View reviewed changes
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one minor doc nit. Thanks!

website/docs/d/efs_mount_target.html.markdown
Provides an Elastic File System Mount Target (EFS) data source.
---

# aws_efs_file_system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use the \ escape prior to the skids here

@stack72
Copy link
Contributor Author

stack72 commented Jul 28, 2017 via email

@sethvargo
Copy link
Contributor

Correct

@grubernaut grubernaut merged commit 51ae86f into hashicorp:master Jul 28, 2017
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grubernaut grubernaut grubernaut approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_efs_mount_target data source
4 participants
@stack72 @sethvargo @grubernaut @Ninir