Do not swallow error when detaching volume

[geek]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSVolumeAttachment*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSVolumeAttachment* -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSVolumeAttachment_basic
=== PAUSE TestAccAWSVolumeAttachment_basic
=== RUN   TestAccAWSVolumeAttachment_skipDestroy
=== PAUSE TestAccAWSVolumeAttachment_skipDestroy
=== RUN   TestAccAWSVolumeAttachment_attachStopped
=== PAUSE TestAccAWSVolumeAttachment_attachStopped
=== RUN   TestAccAWSVolumeAttachment_update
=== PAUSE TestAccAWSVolumeAttachment_update
=== CONT  TestAccAWSVolumeAttachment_basic
=== CONT  TestAccAWSVolumeAttachment_update
=== CONT  TestAccAWSVolumeAttachment_skipDestroy
=== CONT  TestAccAWSVolumeAttachment_attachStopped
...

[bflad]

Thank you for this fix, @geek 🚀

Output from acceptance testing:

--- PASS: TestAccAWSVolumeAttachment_update (84.99s)
--- PASS: TestAccAWSVolumeAttachment_basic (99.04s)
--- PASS: TestAccAWSVolumeAttachment_skipDestroy (200.97s)
--- PASS: TestAccAWSVolumeAttachment_attachStopped (226.76s)

[ghost]

This has been released in version 2.56.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!