resource/aws_appsync_resolver: Add CachingConfig support #12747

ackintosh · 2020-04-09T12:36:52Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

ENHANCEMENTS:

* resource/aws_appsync_resolver: Add `caching_config` block

Output from acceptance testing:

AWS_PROFILE=default make testacc TEST=./aws TESTARGS='-run=TestAccAwsAppsyncResolver_CachingConfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAppsyncResolver_CachingConfig -timeout 120m
=== RUN   TestAccAwsAppsyncResolver_CachingConfig
=== PAUSE TestAccAwsAppsyncResolver_CachingConfig
=== CONT  TestAccAwsAppsyncResolver_CachingConfig
--- PASS: TestAccAwsAppsyncResolver_CachingConfig (89.42s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       89.490s

ackintosh · 2020-04-10T23:19:13Z

The CI job has completed successfully but the status on github is still Pending... 🤔

https://travis-ci.org/github/terraform-providers/terraform-provider-aws/builds/673029687

ackintosh · 2020-04-15T08:23:40Z

Whew, this PR is ready for review!

ackintosh · 2020-05-08T08:12:52Z

This PR closes #13230

ewbankkit · 2020-05-08T11:30:39Z

aws/resource_aws_appsync_resolver.go

+			"caching_config": {
+				Type:     schema.TypeList,
+				Optional: true,
+				Elem: &schema.Resource{


Please add MaxItems: 1, .

ewbankkit · 2020-05-08T11:34:19Z

aws/resource_aws_appsync_resolver.go

+				Elem: &schema.Resource{
+					Schema: map[string]*schema.Schema{
+						"caching_keys": {
+							Type:     schema.TypeList,


I suggest

Type: schema.TypeSet, Set: schema.HashString,

here as order is not important.

ewbankkit · 2020-05-08T11:35:42Z

aws/resource_aws_appsync_resolver.go

+	m := l[0].(map[string]interface{})
+
+	cachingConfig := &appsync.CachingConfig{
+		CachingKeys: expandStringList(m["caching_keys"].([]interface{})),


CachingKeys: expandStringSet(m["caching_keys"].(*schema.Set)),

ewbankkit · 2020-05-08T11:36:48Z

aws/structure.go

+	}
+
+	m := map[string]interface{}{
+		"caching_keys": flattenStringList(c.CachingKeys),


flattenStringSet(c.CachingKeys)

ewbankkit · 2020-05-08T11:37:30Z

aws/structure.go

@@ -5565,6 +5565,23 @@ func flattenAppsyncPipelineConfig(c *appsync.PipelineConfig) []interface{} {
 	return []interface{}{m}
 }

+func flattenAppsyncCachingConfig(c *appsync.CachingConfig) []interface{} {


Maybe move to aws/resource_aws_appsync_resolver.go to avoid overloading this file?

That makes sense, thank you!

I'll also move flattenAppsyncPipelineConfig together with flattenAppsyncCachingConfig to aws/resource_aws_appsync_resolver.go. 💡

Btw, besides flattenAppsync**, I can see some resource-specific function as well in structure.go but I'm not sure why the functions are in the structure.go. 🤔

…onfig

ackintosh · 2020-05-09T12:19:03Z

After the updates, I've checked the acceptance tests have passed. 😌

Output:

$ AWS_PROFILE=default make testacc TEST=./aws TESTARGS='-run=TestAccAwsAppsyncResolver_CachingConfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAppsyncResolver_CachingConfig -timeout 120m
go: downloading github.com/aws/aws-sdk-go v1.30.21
=== RUN   TestAccAwsAppsyncResolver_CachingConfig
=== PAUSE TestAccAwsAppsyncResolver_CachingConfig
=== CONT  TestAccAwsAppsyncResolver_CachingConfig
--- PASS: TestAccAwsAppsyncResolver_CachingConfig (74.90s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       74.945s

ackintosh · 2020-05-09T12:29:40Z

@ewbankkit Thank you for your review! Please have another look when you have time. 😃

ewbankkit · 2020-05-09T20:34:30Z

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsAppsyncResolver_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAwsAppsyncResolver_ -timeout 120m
=== RUN   TestAccAwsAppsyncResolver_basic
=== PAUSE TestAccAwsAppsyncResolver_basic
=== RUN   TestAccAwsAppsyncResolver_disappears
=== PAUSE TestAccAwsAppsyncResolver_disappears
=== RUN   TestAccAwsAppsyncResolver_DataSource
=== PAUSE TestAccAwsAppsyncResolver_DataSource
=== RUN   TestAccAwsAppsyncResolver_RequestTemplate
=== PAUSE TestAccAwsAppsyncResolver_RequestTemplate
=== RUN   TestAccAwsAppsyncResolver_ResponseTemplate
=== PAUSE TestAccAwsAppsyncResolver_ResponseTemplate
=== RUN   TestAccAwsAppsyncResolver_multipleResolvers
=== PAUSE TestAccAwsAppsyncResolver_multipleResolvers
=== RUN   TestAccAwsAppsyncResolver_PipelineConfig
=== PAUSE TestAccAwsAppsyncResolver_PipelineConfig
=== RUN   TestAccAwsAppsyncResolver_CachingConfig
=== PAUSE TestAccAwsAppsyncResolver_CachingConfig
=== CONT  TestAccAwsAppsyncResolver_basic
=== CONT  TestAccAwsAppsyncResolver_multipleResolvers
=== CONT  TestAccAwsAppsyncResolver_CachingConfig
=== CONT  TestAccAwsAppsyncResolver_PipelineConfig
=== CONT  TestAccAwsAppsyncResolver_RequestTemplate
=== CONT  TestAccAwsAppsyncResolver_ResponseTemplate
=== CONT  TestAccAwsAppsyncResolver_DataSource
=== CONT  TestAccAwsAppsyncResolver_disappears
--- PASS: TestAccAwsAppsyncResolver_PipelineConfig (29.86s)
--- PASS: TestAccAwsAppsyncResolver_disappears (30.41s)
--- PASS: TestAccAwsAppsyncResolver_CachingConfig (37.19s)
--- PASS: TestAccAwsAppsyncResolver_multipleResolvers (41.31s)
--- PASS: TestAccAwsAppsyncResolver_ResponseTemplate (46.97s)
--- PASS: TestAccAwsAppsyncResolver_DataSource (50.75s)
--- PASS: TestAccAwsAppsyncResolver_RequestTemplate (50.87s)
--- PASS: TestAccAwsAppsyncResolver_basic (75.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	75.754s

bflad

Thanks @ackintosh 🚀

Output from acceptance testing:

--- PASS: TestAccAwsAppsyncResolver_disappears (17.59s)
--- PASS: TestAccAwsAppsyncResolver_CachingConfig (21.28s)
--- PASS: TestAccAwsAppsyncResolver_PipelineConfig (21.32s)
--- PASS: TestAccAwsAppsyncResolver_ResponseTemplate (27.75s)
--- PASS: TestAccAwsAppsyncResolver_basic (30.41s)
--- PASS: TestAccAwsAppsyncResolver_RequestTemplate (32.44s)
--- PASS: TestAccAwsAppsyncResolver_multipleResolvers (33.10s)
--- PASS: TestAccAwsAppsyncResolver_DataSource (35.67s)

ghost · 2020-05-15T01:03:14Z

This has been released in version 2.62.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

…2747) Output from acceptance testing: ``` --- PASS: TestAccAwsAppsyncResolver_disappears (17.59s) --- PASS: TestAccAwsAppsyncResolver_CachingConfig (21.28s) --- PASS: TestAccAwsAppsyncResolver_PipelineConfig (21.32s) --- PASS: TestAccAwsAppsyncResolver_ResponseTemplate (27.75s) --- PASS: TestAccAwsAppsyncResolver_basic (30.41s) --- PASS: TestAccAwsAppsyncResolver_RequestTemplate (32.44s) --- PASS: TestAccAwsAppsyncResolver_multipleResolvers (33.10s) --- PASS: TestAccAwsAppsyncResolver_DataSource (35.67s) ```

ghost · 2020-06-11T17:10:19Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ackintosh marked this pull request as ready for review April 9, 2020 15:05

ackintosh requested a review from a team April 9, 2020 15:05

ackintosh force-pushed the appsync-caching-config branch 2 times, most recently from 365367d to 5e25214 Compare April 15, 2020 02:54

ackintosh added 5 commits April 15, 2020 16:49

Add CachingConfig support

0c68f11

Update doc for appsync_resolver

e2210b8

Update the pipeline_config section to indented style for easy-read

4ee2303

Add caching_config for Read operation

a8cf87d

Add acceptance test for CachingConfig

6d1b740

ackintosh force-pushed the appsync-caching-config branch from 5e25214 to 6d1b740 Compare April 15, 2020 07:50

ackintosh mentioned this pull request May 8, 2020

resource/aws_appsync_resolver: Add CachingConfig support #13230

Closed

ewbankkit reviewed May 8, 2020

View reviewed changes

ackintosh added 2 commits May 9, 2020 09:45

Add MaxItems

6d0c7cc

Update caching_keys schema

af4c1d6

ackintosh added 2 commits May 9, 2020 10:18

Move AppSync related functions to avoid overloading

6d16f43

Merge remote-tracking branch 'upstream/master' into appsync-caching-c…

19ee1d9

…onfig

bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 11, 2020

bflad approved these changes May 11, 2020

View reviewed changes

bflad added this to the v2.62.0 milestone May 11, 2020

bflad linked an issue May 11, 2020 that may be closed by this pull request

resource/aws_appsync_resolver: Add CachingConfig support #13230

Closed

bflad merged commit ebc3406 into hashicorp:master May 11, 2020

bflad added a commit that referenced this pull request May 11, 2020

Update CHANGELOG for #12747

e539213

ackintosh deleted the appsync-caching-config branch May 11, 2020 23:52

ghost locked and limited conversation to collaborators Jun 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resource/aws_appsync_resolver: Add CachingConfig support #12747

resource/aws_appsync_resolver: Add CachingConfig support #12747

ackintosh commented Apr 9, 2020 •

edited

ackintosh commented Apr 10, 2020

ackintosh commented Apr 15, 2020

ackintosh commented May 8, 2020

ewbankkit May 8, 2020

ewbankkit May 8, 2020

ewbankkit May 8, 2020

ewbankkit May 8, 2020

ewbankkit May 8, 2020

ackintosh May 9, 2020

ackintosh commented May 9, 2020

ackintosh commented May 9, 2020

ewbankkit commented May 9, 2020

bflad left a comment

ghost commented May 15, 2020

ghost commented Jun 11, 2020

resource/aws_appsync_resolver: Add CachingConfig support #12747

resource/aws_appsync_resolver: Add CachingConfig support #12747

Conversation

ackintosh commented Apr 9, 2020 • edited

Community Note

ackintosh commented Apr 10, 2020

ackintosh commented Apr 15, 2020

ackintosh commented May 8, 2020

ewbankkit May 8, 2020

Choose a reason for hiding this comment

ewbankkit May 8, 2020

Choose a reason for hiding this comment

ewbankkit May 8, 2020

Choose a reason for hiding this comment

ewbankkit May 8, 2020

Choose a reason for hiding this comment

ewbankkit May 8, 2020

Choose a reason for hiding this comment

ackintosh May 9, 2020

Choose a reason for hiding this comment

ackintosh commented May 9, 2020

ackintosh commented May 9, 2020

ewbankkit commented May 9, 2020

bflad left a comment

Choose a reason for hiding this comment

ghost commented May 15, 2020

ghost commented Jun 11, 2020

ackintosh commented Apr 9, 2020 •

edited