Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/devicefarm_project - import support #13020

Merged
merged 5 commits into from Jun 17, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12914

Release note for CHANGELOG:

resource_aws_devicefarm_project: import support

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDeviceFarmProject_'
--- PASS: TestAccAWSDeviceFarmProject_basic (42.76s)
--- PASS: TestAccAWSDeviceFarmProject_disappears (35.29s)

@DrFaust92 DrFaust92 requested a review from a team April 25, 2020 16:05
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. service/devicefarm Issues and PRs that pertain to the devicefarm service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 25, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 28, 2020
@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDeviceFarmProject_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSDeviceFarmProject_ -timeout 120m
=== RUN   TestAccAWSDeviceFarmProject_basic
=== PAUSE TestAccAWSDeviceFarmProject_basic
=== RUN   TestAccAWSDeviceFarmProject_disappears
=== PAUSE TestAccAWSDeviceFarmProject_disappears
=== CONT  TestAccAWSDeviceFarmProject_basic
=== CONT  TestAccAWSDeviceFarmProject_disappears
--- PASS: TestAccAWSDeviceFarmProject_disappears (18.28s)
--- PASS: TestAccAWSDeviceFarmProject_basic (23.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	23.223s

remove from state when deleted
add disappears test case
@bflad bflad self-assigned this Jun 17, 2020
@bflad bflad added this to the v2.67.0 milestone Jun 17, 2020
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from acceptance testing:

--- PASS: TestAccAWSDeviceFarmProject_disappears (6.79s)
--- PASS: TestAccAWSDeviceFarmProject_basic (8.64s)

@bflad bflad merged commit f454166 into hashicorp:master Jun 17, 2020
bflad added a commit that referenced this pull request Jun 17, 2020
@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.67.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the r/devicefarm_import branch June 23, 2020 11:16
@ghost
Copy link

ghost commented Jul 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/devicefarm Issues and PRs that pertain to the devicefarm service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support aws_devicefarm_project Resource Import
3 participants