rd/ebs_volume - support multi attach

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13104

Release note for CHANGELOG:

resource_aws_ebs_volume: support multi attach
data_source_aws_ebs_volume: support multi attach

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEBSVolume_'
--- PASS: TestAccAWSEBSVolume_basic (66.31s)
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (295.79s)
--- PASS: TestAccAWSEBSVolume_updateSize (132.89s)
--- PASS: TestAccAWSEBSVolume_updateType (129.24s)
--- PASS: TestAccAWSEBSVolume_updateIops (135.13s)
--- PASS: TestAccAWSEBSVolume_kmsKey (115.12s)
--- PASS: TestAccAWSEBSVolume_NoIops (70.87s)
--- PASS: TestAccAWSEBSVolume_withTags (63.95s)
--- PASS: TestAccAWSEBSVolume_multiAttach (66.32s)

--- PASS: TestAccAWSEbsVolumeDataSource_basic (77.00s)
--- PASS: TestAccAWSEbsVolumeDataSource_multipleFilters (81.83s)

[ewbankkit]

Also add to the equivalent data source?

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEBSVolume_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSEBSVolume_ -timeout 120m
=== RUN   TestAccAWSEBSVolume_basic
=== PAUSE TestAccAWSEBSVolume_basic
=== RUN   TestAccAWSEBSVolume_updateAttachedEbsVolume
=== PAUSE TestAccAWSEBSVolume_updateAttachedEbsVolume
=== RUN   TestAccAWSEBSVolume_updateSize
=== PAUSE TestAccAWSEBSVolume_updateSize
=== RUN   TestAccAWSEBSVolume_updateType
=== PAUSE TestAccAWSEBSVolume_updateType
=== RUN   TestAccAWSEBSVolume_updateIops
=== PAUSE TestAccAWSEBSVolume_updateIops
=== RUN   TestAccAWSEBSVolume_kmsKey
=== PAUSE TestAccAWSEBSVolume_kmsKey
=== RUN   TestAccAWSEBSVolume_NoIops
=== PAUSE TestAccAWSEBSVolume_NoIops
=== RUN   TestAccAWSEBSVolume_withTags
=== PAUSE TestAccAWSEBSVolume_withTags
=== RUN   TestAccAWSEBSVolume_multiAttach
=== PAUSE TestAccAWSEBSVolume_multiAttach
=== RUN   TestAccAWSEBSVolume_outpost
--- SKIP: TestAccAWSEBSVolume_outpost (0.00s)
    resource_aws_ebs_volume_test.go:350: Environment variable AWS_OUTPOST_ARN is not set. This environment variable must be set to the ARN of a deployed Outpost to enable this test.
=== CONT  TestAccAWSEBSVolume_basic
=== CONT  TestAccAWSEBSVolume_kmsKey
=== CONT  TestAccAWSEBSVolume_updateIops
=== CONT  TestAccAWSEBSVolume_multiAttach
=== CONT  TestAccAWSEBSVolume_updateType
=== CONT  TestAccAWSEBSVolume_withTags
=== CONT  TestAccAWSEBSVolume_updateSize
=== CONT  TestAccAWSEBSVolume_NoIops
=== CONT  TestAccAWSEBSVolume_updateAttachedEbsVolume
--- PASS: TestAccAWSEBSVolume_NoIops (39.48s)
--- PASS: TestAccAWSEBSVolume_basic (39.80s)
--- PASS: TestAccAWSEBSVolume_multiAttach (39.86s)
--- PASS: TestAccAWSEBSVolume_withTags (40.36s)
--- PASS: TestAccAWSEBSVolume_kmsKey (46.01s)
--- PASS: TestAccAWSEBSVolume_updateIops (69.62s)
--- PASS: TestAccAWSEBSVolume_updateType (69.84s)
--- PASS: TestAccAWSEBSVolume_updateSize (69.85s)
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (206.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	206.315s

[DrFaust92]

changes to WIP, adding data source

[DrFaust92]

added data source support

[anGie44]

LGTM! Nice refactor 👍
Confirmed acceptance tests as commented by @ewbankkit and additional data_source tests:

--- PASS: TestAccAWSEbsVolumeDataSource_basic (22.20s)
--- PASS: TestAccAWSEbsVolumeDataSource_multipleFilters (22.55s)

[bflad]

Otherwise, looks okay 👍

Output from acceptance testing:

--- PASS: TestAccAWSEBSVolume_kmsKey (21.03s)
--- PASS: TestAccAWSEBSVolume_withTags (21.78s)
--- PASS: TestAccAWSEbsVolumeDataSource_multipleFilters (21.99s)
--- PASS: TestAccAWSEBSVolume_multiAttach (22.04s)
--- PASS: TestAccAWSEBSVolume_basic (22.25s)
--- PASS: TestAccAWSEBSVolume_NoIops (22.51s)
--- PASS: TestAccAWSEbsVolumeDataSource_basic (22.57s)
--- PASS: TestAccAWSEBSVolume_updateSize (38.08s)
--- PASS: TestAccAWSEBSVolume_updateIops (39.14s)
--- PASS: TestAccAWSEBSVolume_updateType (39.19s)
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (150.99s)

[DrFaust92]

@bflad changes made and tested

[anGie44]

@DrFaust92 do you mind adding the attribute re-name change to the data source and website docs as well?

[DrFaust92]

🤦 on it.

[DrFaust92]

added also disappears test

--- PASS: TestAccAWSEBSVolume_disappears (80.95s)

[anGie44]

Awesome, thank you @DrFaust92! Changes LGTM 👍

Confirmed output of acceptance tests in TC:

--- PASS: TestAccAWSEBSVolume_outpost
--- PASS: TestAccAWSEBSVolume_disappears
--- PASS: TestAccAWSEbsVolumeDataSource_basic
--- PASS: TestAccAWSEBSVolume_basic
--- PASS: TestAccAWSEBSVolume_NoIops
--- PASS: TestAccAWSEBSVolume_kmsKey
--- PASS: TestAccAWSEbsVolumeDataSource_multipleFilters
--- PASS: TestAccAWSEBSVolume_multiAttach
--- PASS: TestAccAWSEBSVolume_withTags
--- PASS: TestAccAWSEBSVolume_updateSize
--- PASS: TestAccAWSEBSVolume_updateType
--- PASS: TestAccAWSEBSVolume_updateIops
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume

[ghost]

This has been released in version 2.61.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!